Merge pull request #22 from optimizely/anwar/EHS-50

anwar-opti · web-flow · commit 24253ca6a387 · 2025-11-13T21:02:42.000+06:00
[EHS-50] Add null/undefined checking in canonicalPath in extractPath method
diff --git a/src/fns.js b/src/fns.js
@@ -36,7 +36,7 @@ function extractQueryParams(path) {
  * @return {String}
  */
 function extractPath(base, canonicalPath) {
-  let path = canonicalPath.replace(base, '') || '/'
+  let path = canonicalPath?.replace(base, '') || '/'
   let qsIndex = path.indexOf('?')
   return (qsIndex > -1) ? path.slice(0, qsIndex) : path
 }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ function extractQueryParams(path) {`
`36`	`36`	`* @return {String}`
`37`	`37`	`*/`
`38`	`38`	`function extractPath(base, canonicalPath) {`
`39`		`- let path = canonicalPath.replace(base, '') \|\| '/'`
	`39`	`+ let path = canonicalPath?.replace(base, '') \|\| '/'`
`40`	`40`	`let qsIndex = path.indexOf('?')`
`41`	`41`	`return (qsIndex > -1) ? path.slice(0, qsIndex) : path`
`42`	`42`	`}`