[fssdk-12294] provider config update listener setting

Author: junaed-optimizely

src/hooks/useDecide.spec.tsx

@@ -221,25 +221,6 @@ describe('useDecide', () => {
     expect(result.current.decision).toBe(MOCK_DECISION);
   });
 
-  it('should re-evaluate when setClientReady fire', async () => {
-    const mockUserContext = createMockUserContext();
-    store.setUserContext(mockUserContext);
-    // Client has no config yet
-    const wrapper = createWrapper(store, mockClient);
-    const { result } = renderHook(() => useDecide('flag_1'), { wrapper });
-
-    expect(result.current.isLoading).toBe(true);
-
-    // Simulate config becoming available when onReady resolves
-    (mockClient.getOptimizelyConfig as ReturnType<typeof vi.fn>).mockReturnValue({ revision: '1' });
-    await act(async () => {
-      store.setClientReady(true);
-    });
-
-    expect(result.current.isLoading).toBe(false);
-    expect(result.current.decision).toBe(MOCK_DECISION);
-  });
-
   it('should return error from store with isLoading: false', async () => {
     const wrapper = createWrapper(store, mockClient);
     const { result } = renderHook(() => useDecide('flag_1'), { wrapper });
@@ -363,33 +344,6 @@ describe('useDecide', () => {
     expect(result.current.decision).toBeNull();
   });
 
-  it('should re-call decide() when setClientReady fires after sync decision was already served', async () => {
-    // Sync datafile scenario: config + userContext available before onReady
-    mockClient = createMockClient(true);
-    const mockUserContext = createMockUserContext();
-    store.setUserContext(mockUserContext);
-
-    const wrapper = createWrapper(store, mockClient);
-    const { result } = renderHook(() => useDecide('flag_1'), { wrapper });
-
-    // Decision already served
-    expect(result.current.isLoading).toBe(false);
-    expect(result.current.decision).toBe(MOCK_DECISION);
-    expect(mockUserContext.decide).toHaveBeenCalledTimes(1);
-
-    // onReady() resolves → setClientReady(true) fires → store state changes →
-    // useSyncExternalStore re-renders → useMemo recomputes → decide() called again.
-    // This is a redundant call since config + userContext haven't changed,
-    // but it's a one-time cost per flag per page load.
-    await act(async () => {
-      store.setClientReady(true);
-    });
-
-    expect(mockUserContext.decide).toHaveBeenCalledTimes(2);
-    expect(result.current.isLoading).toBe(false);
-    expect(result.current.decision).toBe(MOCK_DECISION);
-  });
-
   it('should re-evaluate decision when OPTIMIZELY_CONFIG_UPDATE fires from the client', async () => {
     const mockUserContext = createMockUserContext();
     const { wrapper, fireConfigUpdate } = createProviderWrapper(mockUserContext);
@@ -402,6 +356,7 @@ describe('useDecide', () => {
     });
 
     expect(result.current.decision).toBe(MOCK_DECISION);
+
     const callCountBeforeUpdate = (mockUserContext.decide as ReturnType<typeof vi.fn>).mock.calls.length;
 
     // Simulate a new datafile with a different decision

src/hooks/useOptimizelyClient.spec.tsx

@@ -81,12 +81,12 @@ describe('useOptimizelyClient', () => {
 
     // Trigger store state changes that should NOT cause useOptimizelyClient to re-render
     act(() => {
-      store.setClientReady(true);
+      store.setError(new Error('test'));
     });
     expect(capturedRenderCount).toBe(initialRenderCount);
 
     act(() => {
-      store.setError(new Error('test'));
+      store.refresh();
     });
     expect(capturedRenderCount).toBe(initialRenderCount);
   });

src/hooks/useOptimizelyUserContext.spec.tsx

@@ -206,11 +206,11 @@ describe('useOptimizelyUserContext', () => {
 
     const initialRenderCount = capturedRenderCount;
 
-    // Changing isClientReady triggers a store notification,
+    // Triggering a store notification via setState,
     // but since the derived result hasn't changed, useMemo returns
     // the same reference and React bails out
     act(() => {
-      store.setClientReady(true);
+      store.refresh();
     });
 
     expect(capturedRenderCount).toBe(initialRenderCount);

src/provider/OptimizelyProvider.spec.tsx

@@ -154,7 +154,7 @@ describe('OptimizelyProvider', () => {
       expect(mockClient.onReady).toHaveBeenCalledWith({ timeout: 5000 });
     });
 
-    it('should set isClientReady to true when onReady succeeds', async () => {
+    it('should not set error when onReady succeeds', async () => {
       const mockClient = createMockClient({
         onReady: vi.fn().mockResolvedValue(undefined),
       });
@@ -168,13 +168,12 @@ describe('OptimizelyProvider', () => {
 
       await waitFor(() => {
         expect(capturedContext).not.toBeNull();
-        expect(capturedContext!.store.getState().isClientReady).toBe(true);
       });
 
       expect(capturedContext!.store.getState().error).toBeNull();
     });
 
-    it('should set isClientReady to false and set error when onReady rejects', async () => {
+    it('should set error when onReady rejects', async () => {
       const testError = new Error('Client initialization failed');
       const mockClient = createMockClient({
         onReady: vi.fn().mockRejectedValue(testError),
@@ -191,9 +190,6 @@ describe('OptimizelyProvider', () => {
         expect(capturedContext).not.toBeNull();
         expect(capturedContext!.store.getState().error).toBe(testError);
       });
-
-      // Client is NOT ready when onReady rejects
-      expect(capturedContext!.store.getState().isClientReady).toBe(false);
     });
 
     it('should set error when onReady times out (rejects)', async () => {
@@ -213,8 +209,6 @@ describe('OptimizelyProvider', () => {
         expect(capturedContext).not.toBeNull();
         expect(capturedContext!.store.getState().error).toBe(timeoutError);
       });
-
-      expect(capturedContext!.store.getState().isClientReady).toBe(false);
     });
   });
 
@@ -246,15 +240,13 @@ describe('OptimizelyProvider', () => {
 
       await waitFor(() => {
         expect(capturedContext).not.toBeNull();
-        expect(capturedContext!.store.getState().isClientReady).toBe(true);
       });
 
       const store = capturedContext!.store;
 
       unmount();
 
       // Store should be reset
-      expect(store.getState().isClientReady).toBe(false);
       expect(store.getState().userContext).toBeNull();
       expect(store.getState().error).toBeNull();
     });
@@ -572,8 +564,8 @@ describe('OptimizelyProvider', () => {
         resolveOnReady!();
       });
 
-      // Store was reset on unmount, and onReady resolution should not set isClientReady
-      expect(store.getState().isClientReady).toBe(false);
+      // Store was reset on unmount, onReady resolution should not affect store
+      expect(store.getState().error).toBeNull();
     });
 
     it('should call onReady again when client changes', async () => {

src/provider/OptimizelyProvider.tsx

@@ -77,7 +77,8 @@ export function OptimizelyProvider({
     userManagerRef.current.resolveUserContext(user, qualifiedSegments, skipSegments);
   }
 
-  // Effect: Client onReady
+  // Effect: Client onReady — only needed for error handling.
+  // Readiness is derived from userContext + getOptimizelyConfig() by hooks.
   useEffect(() => {
     if (!client) {
       logger?.error('OptimizelyProvider must be passed an Optimizely client instance');
@@ -87,24 +88,11 @@ export function OptimizelyProvider({
 
     let isMounted = true;
 
-    const waitForClientReady = async (): Promise<void> => {
-      try {
-        await client.onReady({ timeout });
-
-        if (!isMounted) return;
-
-        store.setClientReady(true);
-      } catch (error) {
-        if (!isMounted) return;
-        const err = error instanceof Error ? error : new Error(String(error));
-        store.setState({
-          isClientReady: false,
-          error: err,
-        });
-      }
-    };
-
-    waitForClientReady();
+    client.onReady({ timeout }).catch((error) => {
+      if (!isMounted) return;
+      const err = error instanceof Error ? error : new Error(String(error));
+      store.setError(err);
+    });
 
     return () => {
       isMounted = false;
@@ -118,7 +106,7 @@ export function OptimizelyProvider({
     const listenerId = client.notificationCenter.addNotificationListener(
       NOTIFICATION_TYPES.OPTIMIZELY_CONFIG_UPDATE,
       () => {
-        store.setState({});
+        store.refresh();
       }
     );