Fix other issues

Author: esrakartalOpt

spec/cmab_client_spec.rb

@@ -54,7 +54,7 @@
   it 'should return the variation id on success without retrying' do
     client = described_class.new(mock_http_client, nil, spy_logger)
     mock_response = double('response', status_code: 200, json: {'predictions' => [{'variationId' => 'abc123'}]})
-    allow(mock_http_client).to receive(:post).and_return(mock_response)
+    allow(mock_http_client).to receive(:post).and_return(mock_response) 
     result = client.fetch_decision(rule_id, user_id, attributes, cmab_uuid)
     expect(result).to eq('abc123')
     expect(mock_http_client).to have_received(:post).with(
@@ -65,6 +65,7 @@
         timeout: 10
       )
     ).once
+    expect(Kernel).not_to have_received(:sleep)
   end
 
   it 'should return HTTP exception without retrying' do
@@ -76,6 +77,7 @@
     end.to raise_error(Optimizely::CmabFetchError, /Connection error/)
     expect(mock_http_client).to have_received(:post).once
     expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Connection error'))
+    expect(Kernel).not_to have_received(:sleep)
   end
 
   it 'should not return 200 status without retrying' do
@@ -96,6 +98,7 @@
       )
     ).once
     expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('500'))
+    expect(Kernel).not_to have_received(:sleep)
   end
 
   it 'should return invalid json without retrying' do
@@ -117,6 +120,7 @@
       )
     ).once
     expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Invalid CMAB fetch response'))
+    expect(Kernel).not_to have_received(:sleep)
   end
 
   it 'should return invalid response structure without retrying' do
@@ -137,6 +141,7 @@
       )
     ).once
     expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Invalid CMAB fetch response'))
+    expect(Kernel).not_to have_received(:sleep)
   end
 
   it 'should return the variation id on first try with retry config but no retry needed' do
@@ -168,37 +173,21 @@
     success_response = double('response', status_code: 200, json: {'predictions' => [{'variationId' => 'xyz456'}]})
 
     # First two calls fail, third succeeds
-    call_sequence = [failure_response, failure_response, success_response]
-    allow(mock_http_client).to receive(:post) { call_sequence.shift }
+    allow(mock_http_client).to receive(:post).and_return(failure_response, failure_response, success_response)
 
     result = client_with_retry.fetch_decision(rule_id, user_id, attributes, cmab_uuid)
 
     expect(result).to eq('xyz456')
     expect(mock_http_client).to have_received(:post).exactly(3).times
 
-    # Verify all HTTP calls used correct parameters
-    # This expectation should not be here if you want to count calls.
-    # It would be better to assert that the last call had the correct parameters,
-    # or that *any* call had the correct parameters.
-    # For this test, verifying the total call count and sleep times is more relevant.
-    # If you want to check the arguments for each of the 3 calls, you'd need a different approach.
-    # For now, let's remove this specific `with` expectation to avoid conflicts with `exactly(3).times`.
-    # expect(mock_http_client).to have_received(:post).with(
-    #   expected_url,
-    #   hash_including(
-    #     json: expected_body,
-    #     headers: expected_headers,
-    #     timeout: 10
-    #   )
-    # )
-
     # Verify retry logging
-    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 1) after 0.01 seconds...')
-    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 2) after 0.02 seconds...')
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 1) after 0.01 seconds...').once
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 2) after 0.02 seconds...').once
 
     # Verify sleep was called with correct backoff times
     expect(Kernel).to have_received(:sleep).with(0.01).once
     expect(Kernel).to have_received(:sleep).with(0.02).once
+    expect(Kernel).not_to have_received(:sleep).with(0.08)
   end
 
   it 'should exhausts all retry attempts' do
@@ -214,13 +203,13 @@
       client_with_retry.fetch_decision(rule_id, user_id, attributes, cmab_uuid)
     end.to raise_error(Optimizely::CmabFetchError)
 
-    # Verify all attempts were made (1 initial + 3 retries)
+    # Verify all attempts were made (1 initial + 3 retries = 4 calls)
     expect(mock_http_client).to have_received(:post).exactly(4).times
 
     # Verify retry logging
-    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 1) after 0.01 seconds...')
-    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 2) after 0.02 seconds...')
-    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 3) after 0.08 seconds...')
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 1) after 0.01 seconds...').once
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 2) after 0.02 seconds...').once
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 3) after 0.08 seconds...').once
 
     # Verify sleep was called for each retry
     expect(Kernel).to have_received(:sleep).with(0.01).once