[FSSDK-12394] chore: local holdout logic behind FeatureGates flag#631
Open
muzahidul-opti wants to merge 8 commits intomasterfrom
Open
[FSSDK-12394] chore: local holdout logic behind FeatureGates flag#631muzahidul-opti wants to merge 8 commits intomasterfrom
muzahidul-opti wants to merge 8 commits intomasterfrom
Conversation
Default false to suppress local holdout logic until backend is ready. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Both experiment rule and delivery rule local holdout checks are now gated. When false, these blocks are skipped entirely. Global holdout evaluation in getDecisionForFlag() is unaffected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
All holdout test classes set the gate to true in setUp and reset to false in tearDown. Existing test methods are unchanged — they pass because the gate enables the local holdout code paths during test execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…bility FeatureGates.swift was not registered in the Xcode project pbxproj file, causing build failures. Moving into Constants.swift which is already included in all build targets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This test class also uses local holdout data (includedRules), so it needs the gate enabled during test execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Added super.tearDown() to DecisionServiceTests_Holdouts tearDown - Removed FeatureGates override from HoldoutConfigTests since it tests the data model directly, not the gated decision service path Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Coverage is 93.828% — muzahidul/feature-gate-local-holdouts into master. No base build found for |
muzahidul-opti
changed the title
muzahidul-opti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeatureGates.localHoldoutsstatic var (defaultfalse) toConstants.swiftDefaultDecisionService.swiftbehindif FeatureGates.localHoldoutsFeature rollout is ready to ship, but the backend for local holdouts is not yet ready. This gates the local holdout code path so it's suppressed in production while keeping all existing tests passing. Global holdouts are unaffected.
When the backend is ready, flip
FeatureGates.localHoldoutstotrue.Test plan
swift buildandxcodebuildIssues
🤖 Generated with Claude Code