Error decoding old email RSA keys

[kitsah]

Hello,
When I try to login with one of my Proton accounts (I have multiple, and they all work fine except for this one), I receive an error saying “TypeError: encoding without a string argument”

For reference, these are the keys on my account.

I tried generating new Mail keys, marking the RSA ones as compromised, and even deleting them from my account but the error persists.
My account is sort of old (made in 2019) so I still have RSA keys on my account, but ECC (Curve25519) is the current encryption type used for newer accounts. I'm not sure if that's related.

[kitsah]

Update: I was able to fix it by adding
if data == None: return
to the top of the decrypt method in pgp.py.

[opulentfox-29]

Try installing the dev version:

pip install 'git+https://github.com/opulentfox-29/protonmail-api-client.git@skip-old-rsa-keys'

Check installed version (must be 2.1.2)

pip list

Now run your code and check that there are no errors and that you can read the messages. write if everything works, I'll merge the pull request.
Warning: I don't have such an account so I can't reproduce the problem to create a working solution, so I just skip RSA keys, which will make it impossible for you to read messages encrypted with these keys.

[kitsah]

Try installing the dev version:

pip install 'git+https://github.com/opulentfox-29/protonmail-api-client.git@skip-old-rsa-keys'

Check installed version (must be 2.1.2)

pip list

Now run your code and check that there are no errors and that you can read the messages. write if everything works, I'll merge the pull request.
Warning: I don't have such an account so I can't reproduce the problem to create a working solution, so I just skip RSA keys, which will make it impossible for you to read messages encrypted with these keys.

Hello, thank you for these fixes. Unfortunately I'm currently getting a persistent Not Implemented CAPTCHA error that I can't seem to solve. I'll try again in a few days or so.

[opulentfox-29]

I also getting CAPTCHA now, they started to detect simplified (dev) authorization, in the new version 2.2.0 I implemented web-like login type, so the captcha stopped appearing, also in the README.MD I wrote instructions on how to avoid CAPTCHA.

I also merged the new version into the dev branch, so you can try to install the new dev version:

pip install 'git+https://github.com/opulentfox-29/protonmail-api-client.git@skip-old-rsa-keys'

Check installed version (for now, must be 2.2.1)

pip list

And check for errors (I just skip RSA keys, which will make it impossible for you to read messages encrypted with these keys.).

Also good news: I found 2 of my old accounts:

1. registered: 2 Sep 2021. key type: ECC (Curve25519)
2. registered: 29 Aug 2021. key type: RSA (2048)

The difference is only 5 days, but the key types are different :)
So maybe I can implement work with this type of keys later.