Error when logging in

[phinwww]

Logging into ProtonMail...
got cookies
CAPTCHA auto solved
Error: 'ServerProof'

also when trying to save a session:
Error creating session from environment: 'KeySalts'

This is a bug I've encountered.

[johnyttt]

+1

It seems issue is in below code where only 4 api error codes are handled. They do have way more error codes in the api, i've seen at least 3 more not mentioned in the code.

So adding more generic exception there to throw when no known codes encountered might be a good option to go about hanlding it. Especially would be useful to be able to get the error text instead of what we get now

    def _login_process(self, auth: dict) -> bool:
        if auth["Code"] not in (1000, 1001):
            if auth["Code"] in [9001, 12087]:
                raise InvalidCaptcha(auth['Error'])
            if auth["Code"] == 2028:
                raise ConnectionRefusedError(f"Too many recent logins: {auth.get('Error')}")

        self.user.verify_session(b64decode(auth['ServerProof']))

        return self.user.authenticated()

[AdityaGarg8]

Logging into ProtonMail... got cookies CAPTCHA auto solved Error: 'ServerProof'

also when trying to save a session: Error creating session from environment: 'KeySalts'

This is a bug I've encountered.

ServerProof indicates your password was wrong

[hexadecimal233]

More exception types & handling are needed imo