Adding 3 new code examples#93
Merged
Merged
Conversation
1. Wallet Rotation (Should one-time terraform operation) 2. ADB-S secured with OCI Vault / customer-managed keys 3. Long-term backup scheduling / retention policy example for compliance Sign-off by: David Cardenas david.cardenas@oracle.com
malcherm
reviewed
May 26, 2026
Member
malcherm
left a comment
There was a problem hiding this comment.
Most of the comments are around the workload type of Lakehouse and default version 26ai.
| } | ||
|
|
||
| variable "adb_workload_type" { | ||
| description = "Workload type: OLTP (ATP), DW (ADW), AJD (JSON), APEX" |
Member
There was a problem hiding this comment.
Can you please add LH (Lakehouse) here after ATP
| } | ||
|
|
||
| variable "adb_db_version" { | ||
| description = "Oracle database version" |
Member
There was a problem hiding this comment.
Default version should now be 26ai
| adb_db_name = "" | ||
| adb_admin_password = "" | ||
| adb_compute_model = "ECPU" | ||
| adb_workload_type = "DW" # OLTP=ATP | DW=ADW | AJD=JSON | APEX |
| default = "OLTP" | ||
|
|
||
| validation { | ||
| condition = contains(["OLTP", "DW", "AJD", "APEX"], var.adb_workload_type) |
| } | ||
|
|
||
| variable "adb_workload_type" { | ||
| description = "Workload type: OLTP (ATP), DW (ADW), AJD (JSON), APEX" |
| | `adb_db_name` | Database name — letters/numbers only, max 14 characters | — | | ||
| | `adb_admin_password` | ADMIN user password (sensitive) | — | | ||
| | `adb_workload_type` | Workload type: `OLTP` (ATP), `DW` (ADW), `AJD` (JSON), `APEX`, `LH` | `OLTP` | | ||
| | `adb_db_version` | Oracle database version | `19c` | |
| display_name = var.adb_display_name | ||
| db_name = var.adb_db_name | ||
| admin_password = var.adb_admin_password | ||
| db_workload = var.adb_workload_type # OLTP | DW | AJD | APEX |
| | `adb_display_name` | Display name in the OCI console | — | | ||
| | `adb_db_name` | Database name — letters/numbers only, max 14 characters | — | | ||
| | `adb_admin_password` | ADMIN user password (sensitive) | — | | ||
| | `adb_workload_type` | Workload type: `OLTP` (ATP), `DW` (ADW), `AJD` (JSON), `APEX` | `OLTP` | |
Signed-off by: David Cardenas david.cardenas@oracle.com
malcherm
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sign-off by: David Cardenas david.cardenas@oracle.com