Skip to content

Commit b736860

Browse files
authored
Add AssetInitLoading sample and standardize plugin manager usage (#237)
* Add AssetInitLoading sample and standardize plugin manager usage * Update AGENTS review request workflow * Refine AGENTS reviewer selection workflow
1 parent b0c93f7 commit b736860

129 files changed

Lines changed: 25471 additions & 792 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

AGENTS.md

Lines changed: 45 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -15,27 +15,6 @@ In this project, you will 2 kind of plugins within the ./samples folder.
1515

1616
## Commands
1717

18-
If the user asks for `deploy`, you should show them all the environments available. Enviroments should be shown based on this logic.
19-
20-
secure_dir := env_var_or_default("HOME", "") + "/.secure"
21-
22-
In this folder, you will find files with this format $ENV_NAME.secret
23-
24-
e.g if I have 2 files DEMO.secret and PROD.secret, I should respond the user with this
25-
26-
```text
27-
28-
Please select one of these environments :
29-
1. DEMO
30-
2. PROD
31-
```
32-
33-
Once the user selects one of those options, you should execute
34-
35-
just upload $ENV_SELECTED
36-
37-
If the user asks for `create plugin`, you should guide and execute the workflow below.
38-
3918
## Create Plugin Command
4019

4120
When the user asks for `create plugin`, follow these steps in order:
@@ -58,8 +37,52 @@ When the user asks for `create plugin`, follow these steps in order:
5837
10. Switch the current folder/worktree to that new branch.
5938
11. Start the plugin implementation in the proper sample folder or a new sample folder derived from the selected template.
6039

61-
The `create plugin` command is not complete until:
40+
The `create` or `create plugin` command is not complete until:
6241

6342
- the issue has been created
6443
- the branch has been created from the latest remote `main`
6544
- the current folder has been switched to that branch
45+
46+
# Deploy Plugin Command
47+
48+
If the user asks for `deploy` or `deploy plugin` , you should show them all the environments available. Enviroments should be shown based on this logic.
49+
50+
secure_dir := env_var_or_default("HOME", "") + "/.secure"
51+
52+
In this folder, you will find files with this format $ENV_NAME.secret
53+
54+
e.g if I have 2 files DEMO.secret and PROD.secret, I should respond the user with this
55+
56+
```text
57+
58+
Please select one of these environments :
59+
1. DEMO
60+
2. PROD
61+
```
62+
63+
Once the user selects one of those options, you should execute
64+
65+
just upload $ENV_SELECTED
66+
67+
# Commit Plugin Command
68+
69+
If the user asks for `commit` or `commit plugin`, you should execute this workflow:
70+
71+
1. Sync the current working branch with the latest remote state before creating the commit.
72+
2. Review and stage all pending files in the current branch, including tracked and untracked files that belong to the requested work.
73+
3. Create the commit with all staged branch changes.
74+
4. Push the branch to `origin`.
75+
5. Create the Pull Request against the appropriate base branch.
76+
6. Request review on the Pull Request using this rule:
77+
- if the Pull Request author is `miquelgall`, request review from `JamalAkram89` only
78+
- otherwise, request review from `miquelgall` only
79+
80+
The `commit` or `commit plugin` command is not complete until:
81+
82+
- the current branch has been synced with the remote state
83+
- all pending branch files have been staged and committed
84+
- the branch has been pushed to `origin`
85+
- the Pull Request has been created
86+
- the Pull Request has the correct review request based on the Pull Request author:
87+
- `JamalAkram89` only when the author is `miquelgall`
88+
- otherwise `miquelgall` only

samples/000-HelloWorld/justfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ dev-zip: dev-pack
1919
cd dist; zip plugin.zip index.html main.js
2020

2121
upload:
22-
pluginmgr --filename dist/plugin.zip upload HelloWorld
22+
npx pluginmgr --filename dist/plugin.zip upload HelloWorld

0 commit comments

Comments
 (0)