Merge pull request #205 from oracle/jet-template-linting

Updating ESLint config for node-jet template

Author: LeonSilva15

templates/node-jet/eslint.config.mjs

@@ -5,10 +5,72 @@
 ** Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
 */
 
-import eslint from "@eslint/js";
-import tseslint from "typescript-eslint";
+import globals from "globals";
+import js from "@eslint/js";
+import nodePlugin from "eslint-plugin-n";
+import tseslintPlugin from "@typescript-eslint/eslint-plugin";
+import tseslintParser from "@typescript-eslint/parser";
 
-export default tseslint.config(
-    eslint.configs.recommended,
-    ...tseslint.configs.recommended
-);
+export default [
+  {
+    files: ["src/**/*.ts", "src/**/*.tsx"],
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: "module",
+      parser: tseslintParser,
+      parserOptions: {
+        ecmaFeatures: {
+          modules: true
+        },
+        ecmaVersion: "2022",
+        project: "./tsconfig.json",
+      },
+      globals: {
+        ...globals.browser,
+      }
+    },
+    plugins: {
+      "@typescript-eslint": tseslintPlugin
+    },
+    rules: {
+      ...js.configs.recommended.rules,
+      ...tseslintPlugin.configs["eslint-recommended"].overrides[0].rules,
+      ...tseslintPlugin.configs["recommended"].rules,
+      "@typescript-eslint/no-require-imports": "off",
+      "@typescript-eslint/no-unused-vars": "warn",
+      "prefer-const": "warn",
+    }
+  },
+  {
+    files: ["src/**/*.js"],
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: "module",
+      globals: {
+        ...globals.browser,
+        ...globals.amd
+      }
+    },
+    rules: {
+        ...js.configs.recommended.rules,
+        "no-undef": "warn"
+    }
+  },
+  {
+    files: ["server/**/*.js", "server/**/*.cjs"],
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: "module",
+      globals: {
+        ...globals.node,
+      }
+    },
+    plugins: {
+      n: nodePlugin
+    },
+    rules: {
+      ...js.configs.recommended.rules,
+      ...nodePlugin.configs["flat/recommended-script"].rules
+    }
+  }
+];

templates/node-jet/package.json

@@ -4,7 +4,7 @@
   "description": "An Oracle JavaScript Extension Toolkit(JET) web app",
   "scripts": {
     "dev": "concurrently --names server,client --prefix-colors blue,yellow --success all --kill-others 'node ./server/index.cjs' 'ojet serve --server-only'",
-    "lint": "eslint src/ --max-warnings 0"
+    "lint": "eslint --report-unused-disable-directives"
   },
   "dependencies": {
     "@oracle/oraclejet": "~17.1.0",
@@ -28,7 +28,10 @@
     "concurrently": "^9.1.2",
     "eslint": "^9.18.0",
     "@eslint/js": "^9.18.0",
-    "typescript-eslint": "8.20.0"
+    "eslint-plugin-n": "^17.15.1",
+    "@typescript-eslint/eslint-plugin": "^8.21.0",
+    "@typescript-eslint/parser": "^8.21.0",
+    "globals": "15.14.0"
   },
   "engines": {
     "node": ">=16.0.0"

templates/node-jet/src/components/content/index.tsx

@@ -17,7 +17,6 @@ async function updateDatabaseStatus() {
 
       return 'Database is working!';
   } catch ( error ) {
-      // eslint-disable-next-line no-console
       console.error( 'Error fetching connection status:', error );
       return 'Something is wrong with the database!';
   }