Feature/adding oracle apex#2952
Conversation
Initial Commit
… into feature/Adding_Oracle_Apex
Uncomment the functions
Updated hostname
Update to generate pool.xml file by script
gamagecb
requested review from
Djelibeybi,
gvenzl,
mriccell and
rjeberhard
as code owners
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
|
|
||
| LICENSE UPL 1.0 | ||
|
|
||
| Copyright (c) 2014-2017 Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
This is a brand new file. It should be Copyright (c) 2025 Oracle and/or its affiliates.
Oracle no longer includes the phrase "all rights reserved"
| ## Support | ||
|
|
There was a problem hiding this comment.
If there is no content for this section, it should be removed.
|
|
||
| ## Copyright | ||
|
|
||
| Copyright (c) 2014-2017 Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
As before, the copyright date is incorrect and "all rights reserved" should be removed.
|
|
||
| USER root | ||
| # Install Java 11 OpenJDK | ||
| RUN yum install -y java-11-openjdk-devel |
There was a problem hiding this comment.
Please add && rm -rf /var/cache/yum to this directive to reduce the size of the layer.
| @@ -0,0 +1,28 @@ | |||
| # Use Oracle 19c image as the base | |||
There was a problem hiding this comment.
Please add a copyright header to this file.
| SysPassw0rd | ||
| ApexPassw0rd |
There was a problem hiding this comment.
Oracle does not permit the use of fixed passwords. These need to be randomly generated at runtime.
| @@ -0,0 +1,81 @@ | |||
| # LICENSE UPL 1.0 | |||
There was a problem hiding this comment.
Do not commit backup/old files. This should be removed.
| @@ -0,0 +1,21 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Please add a copyright header
| @@ -0,0 +1,37 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Please add a copyright header
| Follow the instructions on the Docker official documentation to install Docker Desktop on Windows: | ||
| - [Docker Desktop Installation for Windows](https://docs.docker.com/desktop/install/windows-install/) |
There was a problem hiding this comment.
You should provide instructions for how to deploy this on Oracle Linux using Podman, as this would be the most common deployment scenario on an OCI instance.
|
Update for Apex 24.2 |
|
You haven't signed the OCA. If you're an Oracle employee, you need to fix your commits and your GitHub account so that the OCA bot detects them correctly. |
|
You also have not addressed any of the issues I raised in my first review. |
2 participants
Added Apex 24.2 version