Skip to content

[GR-76369] Wait for faulthandler thread dumps #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graalvmbot merged 1 commit into from
Jun 8, 2026
Merged

[GR-76369] Wait for faulthandler thread dumps #933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 33 additions & 4 deletions ...graal.python/src/com/oracle/graal/python/builtins/modules/FaulthandlerModuleBuiltins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.List;
import java.util.concurrent.CancellationException;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;

import com.oracle.graal.python.PythonLanguage;
import com.oracle.graal.python.annotations.ArgumentClinic;
Expand Down Expand Up @@ -155,7 +160,7 @@ PNone doit(VirtualFrame frame, Object fileObj, boolean allThreads,
Object state = BoundaryCallContext.enter(frame, language, context, boundaryCallData);
try {
// it's not important for this to be fast at all
dump(language, context, fileno, fileObj, allThreads);
dump(inliningTarget, language, context, fileno, fileObj, allThreads);
} finally {
BoundaryCallContext.exit(frame, language, context, state);
}
Expand All @@ -164,21 +169,45 @@ PNone doit(VirtualFrame frame, Object fileObj, boolean allThreads,
}

@TruffleBoundary
static void dump(PythonLanguage language, PythonContext context, int fd, Object fileObj, boolean allThreads) {
static void dump(Node inliningTarget, PythonLanguage language, PythonContext context, int fd, Object fileObj, boolean allThreads) {
if (allThreads) {
context.getEnv().submitThreadLocal(context.getThreads(), new ThreadLocalAction(true, false) {
Future<Void> future = context.getEnv().submitThreadLocal(context.getThreads(), new ThreadLocalAction(true, false) {
@Override
protected void perform(ThreadLocalAction.Access access) {
dumpTraceback(language, newRawFdPrintWriter(fd));
}
});
waitForDumpTraceback(inliningTarget, future);
} else {
dumpTraceback(language, newRawFdPrintWriter(fd));
}
// Keep the file object alive to make sure the fd doesn't get closed
Reference.reachabilityFence(fileObj);
}

private static void waitForDumpTraceback(Node inliningTarget, Future<Void> future) {
GilNode gil = GilNode.getUncached();
boolean gilReleased = gil.tryRelease();
try {
TruffleSafepoint.setBlockedThreadInterruptible(inliningTarget, voidFuture -> {
try {
voidFuture.get(10, TimeUnit.SECONDS);
} catch (TimeoutException e) {
throw PRaiseNode.raiseStatic(inliningTarget, PythonBuiltinClassType.RuntimeError,
tsLiteral("Failed to dump traceback from all threads within 10 seconds"));
} catch (CancellationException e) {
// Ignore
} catch (ExecutionException e) {
throw new RuntimeException(e);
}
}, future);
} finally {
if (gilReleased) {
gil.acquire(PythonContext.get(null), inliningTarget);
}
}
}

@Override
protected ArgumentClinicProvider getArgumentClinic() {
return FaulthandlerModuleBuiltinsClinicProviders.DumpTracebackNodeClinicProviderGen.INSTANCE;
Expand Down Expand Up @@ -325,7 +354,7 @@ private static void doDumpLater(Node inliningTarget, PythonModule module, long t
timeoutWriter.printf("Timeout (%d:%02d:%02d)!%n", timeoutS / 3600, timeoutS / 60, timeoutS);
timeoutWriter.flush();
try {
DumpTracebackNode.dump(context.getLanguage(), context, fd, fileObj, true);
DumpTracebackNode.dump(inliningTarget, context.getLanguage(), context, fd, fileObj, true);
if (exit) {
// Sleep for a bit to give time for the safepoint-based
// printing to execute before we exit
Expand Down
Loading