Ensure to use computed reference on copy (#572)

Author: jonesbusy

src/main/java/land/oras/CopyUtils.java

@@ -127,12 +127,12 @@ void copy(
         // Index
         else if (source.isIndexMediaType(contentType)) {
 
-            Index index = source.getIndex(sourceRef);
-            String tag = sourceRef.getTag();
+            Index index = source.getIndex(effectiveSourceRef);
+            String tag = effectiveSourceRef.getTag();
 
             // Write all manifests and their config
             for (ManifestDescriptor manifestDescriptor : index.getManifests()) {
-                Manifest manifest = source.getManifest(sourceRef.withDigest(manifestDescriptor.getDigest()));
+                Manifest manifest = source.getManifest(effectiveSourceRef.withDigest(manifestDescriptor.getDigest()));
 
                 // Push config
                 copyConfig(manifest, source, effectiveSourceRef, target, effectiveTargetRef);

src/test/java/land/oras/DockerIoITCase.java

@@ -102,4 +102,35 @@ void shouldCopyTagToInternalRegistry() {
         CopyUtils.copy(sourceRegistry, containerSource, targetRegistry, containerTarget, true);
         assertTrue(targetRegistry.exists(containerTarget));
     }
+
+    @Test
+    @Execution(ExecutionMode.SAME_THREAD)
+    void shouldCopyTagToInternalRegistryViaAlias(@TempDir Path homeDir) throws Exception {
+
+        // language=toml
+        String config =
+                """
+            [aliases]
+            "dockerhub-alpine" = "docker.io/library/alpine"
+            """;
+        TestUtils.createRegistriesConfFile(homeDir, config);
+
+        TestUtils.withHome(homeDir, () -> {
+            // Source registry
+            Registry sourceRegistry = Registry.Builder.builder().defaults().build();
+
+            // Copy to this internal registry
+            Registry targetRegistry = Registry.Builder.builder()
+                    .defaults("myuser", "mypass")
+                    .withInsecure(true)
+                    .build();
+
+            ContainerRef containerSource = ContainerRef.parse("dockerhub-alpine");
+            ContainerRef containerTarget =
+                    ContainerRef.parse("%s/docker/library/alpine:latest".formatted(unsecureRegistry.getRegistry()));
+
+            CopyUtils.copy(sourceRegistry, containerSource, targetRegistry, containerTarget, true);
+            assertTrue(targetRegistry.exists(containerTarget));
+        });
+    }
 }