Fix mount for insecure registry (parameter order) (#652)

Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>

Author: jonesbusy

src/main/java/land/oras/Registry.java

@@ -155,7 +155,7 @@ public boolean mountBlob(ContainerRef sourceRef, ContainerRef targetRef) {
         }
         ContainerRef ref = targetRef.forRegistry(this).checkBlocked(this);
         if (ref.isInsecure(this) && !this.isInsecure()) {
-            return asInsecure().mountBlob(targetRef, sourceRef);
+            return asInsecure().mountBlob(sourceRef, targetRef);
         }
         URI uri = URI.create("%s://%s".formatted(getScheme(), ref.getBlobsMountPath(this, sourceRef)));
         HttpClient.ResponseWrapper<String> response = client.post(

src/test/java/land/oras/RegistryTest.java

@@ -283,6 +283,54 @@ void shouldCheckIfCanMount() throws IOException {
                 "Should not mount if different reference type");
     }
 
+    @Test
+    void shouldMountWithInsecureRegistry(@TempDir Path homeDir) throws Exception {
+
+        // language=toml
+        String config =
+                """
+            [[registry]]
+            location = "%s"
+            insecure = true
+            """
+                        .formatted(this.unsecureRegistry.getRegistry());
+        TestUtils.createRegistriesConfFile(homeDir, config);
+
+        TestUtils.withHome(homeDir, () -> {
+            Registry registry = Registry.builder()
+                    .defaults(this.unsecureRegistry.getRegistry())
+                    .build();
+
+            byte[] content = "foo".getBytes(StandardCharsets.UTF_8);
+            String digest = SupportedAlgorithm.getDefault().digest(content);
+            ContainerRef sourceRef = ContainerRef.parse("library/artifact-mount-insecure-source");
+            ContainerRef targetRef = ContainerRef.parse("library/artifact-mount-insecure-target");
+            Layer layer = registry.pushBlob(sourceRef.withDigest(digest), content);
+            registry.mountBlob(sourceRef.withDigest(digest), targetRef.withDigest(digest));
+
+            // Ensure we can reference from both artifact
+            Manifest manifestSource = Manifest.empty().withLayers(List.of(layer));
+            Manifest manifestTarget = Manifest.empty().withLayers(List.of(layer));
+
+            // Push the empty config
+            registry.pushConfig(sourceRef, Config.empty());
+
+            // Mount also the config
+            String configDigest = Config.empty().getDigest();
+            assertNotNull(configDigest, "Config digest should not be null");
+            registry.mountBlob(sourceRef.withDigest(configDigest), targetRef.withDigest(configDigest));
+
+            registry.pushManifest(sourceRef, manifestSource);
+            registry.pushManifest(targetRef, manifestTarget);
+            assertThrows(
+                    OrasException.class,
+                    () -> {
+                        registry.mountBlob(sourceRef, targetRef.withDigest(configDigest));
+                    },
+                    "Missing digest");
+        });
+    }
+
     @Test
     void shouldMount() {
         Registry registry = Registry.builder()