Do not include auth header when redirecting to other domain or when switching to insecure protocol#334
Merged
jonesbusy merged 1 commit intoJun 21, 2025
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
============================================
+ Coverage 87.91% 88.00% +0.09%
- Complexity 617 627 +10
============================================
Files 39 39
Lines 1886 1893 +7
Branches 208 211 +3
============================================
+ Hits 1658 1666 +8
Misses 135 135
+ Partials 93 92 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3c5059 to
178a003
Compare
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
178a003 to
682edfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not send credentials to other demain. Also now S3 reject Authorization header when signature is passed throught URL
Testing done
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR