Make ArchiveUtils work on Windows#683
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (63.15%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
============================================
+ Coverage 87.01% 87.40% +0.38%
- Complexity 963 965 +2
============================================
Files 43 44 +1
Lines 2988 3000 +12
Branches 374 377 +3
============================================
+ Hits 2600 2622 +22
+ Misses 228 216 -12
- Partials 160 162 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Handle POSIX permissions only on compatible OSes, with fallback on default, standard permissions. * Include check to ensure the OS support symlinks before creating them. On Windows, a warning is logged when trying to create a symlink without the necessary permissions. Fixes oras-projectgh-671 Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Collaborator
|
Thanks. Looks good. I will merge and this will help for #690 |
jonesbusy
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes gh-671
Testing done
Confirmed the automated tests for
ArchiveUtilsstill work on macOS and Linux. I ran manual tests on Windows forArchiveUtilsspecifically since some of the other tests can't run on Windows (I can see that's being handled in #690. That might reveal more areas than ArchiveUtils to update to make them work on Windows as well).Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR