Skip to content

Add missing @OrasModel annotation on CredentialHelperResponse#685

Merged
jonesbusy merged 1 commit into
oras-project:mainfrom
ThomasVitale:gh-684
Apr 18, 2026
Merged

Add missing @OrasModel annotation on CredentialHelperResponse#685
jonesbusy merged 1 commit into
oras-project:mainfrom
ThomasVitale:gh-684

Conversation

@ThomasVitale
Copy link
Copy Markdown
Contributor

Description

Add missing @OrasModel annotation on CredentialHelperResponse to allow access when compiled to a GraalVM native executable.

Fixes gh-684

Testing done

Updated tests for for model annotations.

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

Fixes oras-projectgh-684

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@ThomasVitale ThomasVitale requested a review from jonesbusy as a code owner April 18, 2026 10:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (8d8a5e6) to head (08f5788).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #685      +/-   ##
============================================
+ Coverage     86.70%   87.28%   +0.58%     
  Complexity      943      943              
============================================
  Files            43       43              
  Lines          2910     2910              
  Branches        364      364              
============================================
+ Hits           2523     2540      +17     
+ Misses          229      212      -17     
  Partials        158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy
Copy link
Copy Markdown
Collaborator

Thanks! Good catch!

@jonesbusy jonesbusy merged commit f230da5 into oras-project:main Apr 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing @OrasModel on CredentialHelperResponse for reflection access

2 participants