add support for lyrical#196
Conversation
christian-rauch
force-pushed
the
lyrical
branch
2 times, most recently
from
42ecd92 to
aeb1670
Compare
christian-rauch
changed the title
|
@ob-yalian Can you have a look at this PR to get the |
christian-rauch
force-pushed
the
lyrical
branch
3 times, most recently
from
2d32b93 to
292275b
Compare
|
@ob-yalian @jjiszjj @winf Can you comment on this PR or let me otherwise know, who is maintaining this repo and who I should contact? |
|
@christian-rauch Sorry for the late reply. Thanks for the reminder and for all the work you've put into this PR. I'll review the changes as soon as possible and get back to you with feedback. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 292275b83b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@ob-yalian @obshenlanzhou Can you check the codex review and my responses? I am not sure how much sense they make. Can you comment on your own what the issues with the proposed changes are? |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@ob-yalian @obshenlanzhou I also addressed the codex comments. Can you please review this again? |
3 participants
This adds support for ROS 2
lyricalby mainly replacingament_target_dependencieswith the targets fortarget_link_libraries.