Fixing Global timestamps in tools/benchmark#138
Open
SebastianMunozP wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the contribution and the clear write-up! We actually have an internal development build that already covers this functionality, and we plan to release it on GitHub in the near future. Because of that, we won't be merging this PR — but the motivation here is exactly right, and it aligns closely with what we were already building. Really appreciate you taking the time to put this together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue: #139
Currently, the GlobalTimestamps of the reports provided by this tool are all zeroes, this is because GlobalTimestamps are not being enabled before being used. This PR fixes this issue by enabling them.
Before
summary.csv
0.csv
AARK753002H_timestamp_difference_depth.csv
AARK753002H_timestamp_difference_color.csv
After
summary.csv
0.csv
AARK753002H_timestamp_difference_depth.csv
AARK753002H_timestamp_difference_color.csv