GlobalTimestampFitter: custom host timestamp#160
Open
wolfd wants to merge 1 commit into
Open
Conversation
This change allows the SDK user to provide a custom timestamp function. The current default timestamp function gets the global time, which is subject to NTP updates. Some users (e.g. me) might want to replace the estimated timestamp with their own function so that we can use a monotonic time source. `IGlobalTimestampFitter` gets two new methods: - `setHostClockFn`: replace the default clock function with a custom one - `setMaxValidRtt`: now exposed in the interface, the max RTT before discarding a time sample. `HostClockFn` is expected to return a microsecond time value. The new functionality is also exposed in the C API.
Collaborator
|
Thanks for the contribution and the clear write-up! We actually have an internal development build that already supports a monotonic host timestamp source for the global timestamp fitter, and we plan to release it on GitHub in the near future. Because of that, we won't be merging this PR — but the motivation here is exactly right, and it lined up with what we were already building. Really appreciate you taking the time to put this together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the SDK user to provide a custom timestamp function. The current default timestamp function gets the global time, which is subject to NTP updates. Some users (e.g. me) might want to replace the estimated timestamp with their own function so that we can use a monotonic time source.
IGlobalTimestampFittergets two new methods:setHostClockFn: replace the default clock function with a custom onesetMaxValidRtt: now exposed in the interface, the max RTT before discarding a time sample.HostClockFnis expected to return a microsecond time value.The new functionality is also exposed in the C API.