Make DB connection name configurable#38
Open
Neluxx wants to merge 18 commits into
Open
Conversation
krugerman007
approved these changes
May 28, 2026
ravage84
requested changes
May 28, 2026
Co-authored-by: Marc Würth <ravage@bluewin.ch>
Co-authored-by: Marc Würth <ravage@bluewin.ch>
ravage84
requested changes
May 28, 2026
Co-authored-by: Marc Würth <ravage@bluewin.ch>
Member
Author
|
I tested the changes locally on one of our internal projects. Everything works as expected. |
krugerman007
approved these changes
May 29, 2026
Member
|
@krugerman007 can you please require this dev branch of this package in our project which uses it and create a MR to showcase? If I remember correctly, we have a second ORACLE DB connection in that project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied the code from @liviakuenzli pull request #23 with small adjustments.
I still need to test it thoroughly, but the code itself looks good.
To Do:
Closes #14