You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Included a metadata field in each entity table called time_index_attribute with type array(String). Identifiedall attributes linked to the time_index. Stored the list of attributes in the field time_index_attribute. In the attribute related queries, retrieved rows where time_index_attribute includes the attribute or where time_index_attribute is Null.
Types of changes
What types of changes does your code introduce to the project: Put
an x in the boxes that apply
[ x ] Bugfix (non-breaking change which fixes an issue)
[ x ] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing
functionality to not work as expected)
Checklist
Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.
Hi guys, I'm struggling to make sense of this PR. I can see the implementation but I can't remember what the actual use case for this change was. Help! :-)
Hi guys, I'm struggling to make sense of this PR. I can see the implementation but I can't remember what the actual use case for this change was. Help! :-)
when a new entry is recorded, the information which attributes are linked to the time_index stored is lost so we Included metadata field time_index_attribute with type array.
In this PR we identified attributes linked to the time_index and stored the list of attributes in the field time_index_attribute while storing the entity.
In attribute related queries we retrieved only rows where time_index_attribute includes the attribute or where time_index_attribute is null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Included a metadata field in each entity table called time_index_attribute with type array(String). Identifiedall attributes linked to the time_index. Stored the list of attributes in the field time_index_attribute. In the attribute related queries, retrieved rows where time_index_attribute includes the attribute or where time_index_attribute is Null.
Types of changes
What types of changes does your code introduce to the project: Put
an
xin the boxes that applyfunctionality to not work as expected)
Checklist
Put an
xin the boxes that apply. You can also fill these out aftercreating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.
feature works
downstream modules
Further comments
Fix for Issue