🐛 filters with zero are dropped #73

Author: Crhistian

codegen/templates/utils/paramsSerializer.ts

@@ -18,8 +18,8 @@ export default function ParamSerializer(originalParams: {
           valuesArray.push(`${key}=${encodeURIComponent(val)}`)
         )
       }
-      // exclude null, undefined, or empty string but permit boolean false to be serialized
-      else if (typeof filterVal === 'boolean' || filterVal) {
+      // exclude null, undefined, or empty string but permit boolean false, and 0 to be serialized
+      else if (typeof filterVal === 'boolean' || filterVal === 0 || filterVal) {
         valuesArray.push(`${key}=${encodeURIComponent(filterVal)}`)
       }
     }

src/utils/paramsSerializer.ts

@@ -18,8 +18,8 @@ export default function ParamSerializer(originalParams: {
           valuesArray.push(`${key}=${encodeURIComponent(val)}`)
         )
       }
-      // exclude null, undefined, or empty string but permit boolean false to be serialized
-      else if (typeof filterVal === 'boolean' || filterVal) {
+      // exclude null, undefined, or empty string but permit boolean false, and 0 to be serialized
+      else if (typeof filterVal === 'boolean' || filterVal === 0 || filterVal) {
         valuesArray.push(`${key}=${encodeURIComponent(filterVal)}`)
       }
     }

tests/paramsSerializer.test.ts

@@ -78,3 +78,21 @@ test('should allow true boolean', () => {
   }
   expect(serialize(params)).toBe('FirstName=Bob&IsSubmitted=true')
 })
+
+test('should allow number filters', () => {
+  const params = {
+    filters: {
+      SpecCount: 3,
+    },
+  }
+  expect(serialize(params)).toBe('SpecCount=3')
+})
+
+test('should not drop 0 filters', () => {
+  const params = {
+    filters: {
+      SpecCount: 0,
+    },
+  }
+  expect(serialize(params)).toBe('SpecCount=0')
+})