chore(tests): extending test coverage

Author: orenlab

CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## [Unreleased]
+## [2.0.0b3]
 
 ### Licensing
 
@@ -10,8 +10,6 @@
 
 - Ship both `LICENSE` and `LICENSE-docs`, update package metadata, and sync file-level SPDX headers.
 
-## [2.0.0b3]
-
 ### MCP server
 
 - Add optional `codeclone[mcp]` extra with `codeclone-mcp` launcher (`stdio` and `streamable-http` transports).

tests/test_baseline.py

@@ -7,6 +7,7 @@
 import json
 from collections.abc import Callable
 from pathlib import Path
+from typing import Any, cast
 
 import pytest
 
@@ -225,6 +226,16 @@ def test_baseline_load_legacy_payload(tmp_path: Path) -> None:
     assert exc.value.status == "missing_fields"
 
 
+def test_baseline_load_rejects_non_object_preloaded_payload(tmp_path: Path) -> None:
+    baseline_path = tmp_path / "baseline.json"
+    _write_payload(baseline_path, _trusted_payload())
+    baseline = Baseline(baseline_path)
+
+    with pytest.raises(BaselineValidationError, match="must be an object") as exc:
+        baseline.load(preloaded_payload=cast(Any, []))
+    assert exc.value.status == "invalid_type"
+
+
 def test_baseline_load_missing_top_level_key(tmp_path: Path) -> None:
     baseline_path = tmp_path / "baseline.json"
     _write_payload(baseline_path, {"meta": {}})
@@ -784,6 +795,25 @@ def _boom_stat(self: Path) -> object:
     assert exc.value.status == "invalid_type"
 
 
+def test_baseline_atomic_write_json_cleans_up_temp_file_on_replace_failure(
+    tmp_path: Path,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    path = tmp_path / "baseline.json"
+    temp_holder: dict[str, Path] = {}
+
+    def _boom_replace(src: str | Path, dst: str | Path) -> None:
+        temp_holder["path"] = Path(src)
+        raise OSError("replace failed")
+
+    monkeypatch.setattr("codeclone.baseline.os.replace", _boom_replace)
+
+    with pytest.raises(OSError, match="replace failed"):
+        baseline_mod._atomic_write_json(path, _trusted_payload())
+
+    assert temp_holder["path"].exists() is False
+
+
 def test_baseline_load_json_read_error(
     tmp_path: Path, monkeypatch: pytest.MonkeyPatch
 ) -> None:
@@ -818,6 +848,22 @@ def test_baseline_optional_str_paths(tmp_path: Path) -> None:
     assert exc.value.status == "invalid_type"
 
 
+def test_baseline_require_utc_iso8601_z_rejects_invalid_calendar_date(
+    tmp_path: Path,
+) -> None:
+    path = tmp_path / "baseline.json"
+    with pytest.raises(
+        BaselineValidationError,
+        match="'created_at' must be UTC ISO-8601 with Z",
+    ) as exc:
+        baseline_mod._require_utc_iso8601_z(
+            {"created_at": "2026-02-31T00:00:00Z"},
+            "created_at",
+            path=path,
+        )
+    assert exc.value.status == "invalid_type"
+
+
 def test_baseline_load_legacy_codeclone_version_alias(tmp_path: Path) -> None:
     baseline_path = tmp_path / "baseline.json"
     payload = _trusted_payload(generator_version="1.4.0")

tests/test_cache.py

@@ -1277,6 +1277,73 @@ def test_decode_wire_file_entry_optional_source_stats() -> None:
     )
 
 
+def test_cache_helpers_cover_invalid_analysis_profile_and_source_stats_shapes() -> None:
+    assert (
+        cache_mod._decode_wire_qualname_span_size(["pkg.mod:fn", 1, 2, "bad"]) is None
+    )
+    assert cache_mod._decode_wire_qualname_span_size([None, 1, 2, 4]) is None
+    assert (
+        cache_mod._as_analysis_profile(
+            {
+                "min_loc": 1,
+                "min_stmt": 1,
+                "block_min_loc": 2,
+                "block_min_stmt": "bad",
+                "segment_min_loc": 3,
+                "segment_min_stmt": 4,
+            }
+        )
+        is None
+    )
+    assert (
+        cache_mod._decode_optional_wire_source_stats(obj={"ss": [1, 2, "bad", 0]})
+        is None
+    )
+
+
+def test_canonicalize_cache_entry_skips_invalid_dead_candidate_suppression_shape() -> (
+    None
+):
+    normalized = cache_mod._canonicalize_cache_entry(
+        cast(
+            Any,
+            {
+                "stat": {"mtime_ns": 1, "size": 2},
+                "units": [],
+                "blocks": [],
+                "segments": [],
+                "class_metrics": [],
+                "module_deps": [],
+                "dead_candidates": [
+                    {
+                        "qualname": "pkg.mod:unused",
+                        "local_name": "unused",
+                        "filepath": "pkg/mod.py",
+                        "start_line": 1,
+                        "end_line": 2,
+                        "kind": "function",
+                        "suppressed_rules": "dead-code",
+                    }
+                ],
+                "referenced_names": [],
+                "referenced_qualnames": [],
+                "import_names": [],
+                "class_names": [],
+            },
+        )
+    )
+    assert normalized["dead_candidates"] == [
+        {
+            "qualname": "pkg.mod:unused",
+            "local_name": "unused",
+            "filepath": "pkg/mod.py",
+            "start_line": 1,
+            "end_line": 2,
+            "kind": "function",
+        }
+    ]
+
+
 def test_decode_optional_wire_coupled_classes_rejects_non_string_qualname() -> None:
     assert (
         cache_mod._decode_optional_wire_coupled_classes(
@@ -1562,6 +1629,18 @@ def test_cache_type_predicates_reject_non_dict_variants() -> None:
     assert cache_mod._is_class_metrics_dict([]) is False
     assert cache_mod._is_module_dep_dict([]) is False
     assert cache_mod._is_dead_candidate_dict([]) is False
+    assert (
+        cache_mod._is_dead_candidate_dict(
+            {
+                "qualname": "pkg.mod:broken",
+                "local_name": "broken",
+                "filepath": "pkg/mod.py",
+                "start_line": 1,
+                "end_line": 2,
+            }
+        )
+        is False
+    )
     assert (
         cache_mod._is_dead_candidate_dict(
             {