Use jq syntax from atom jq support

[wader]

Difference to current syntax:
Supports string interpolation highlighting
Add foreach keyword
def name and function highlighting the same

Additional to atom syntax:
Better array/pattern support
Add //? operator

Was convert using:
cson2json < language-jq/grammars/jq.cson > jq.tmLanguage.json

Related PR to update CSON grammar wader/language-jq#5

[wader]

Sorry if messed up something, i'm very new to vscode syntax highlighting and exensions

Comparison:

[wader]

I noticed that there is something wrong with handling of .. as {$var}, looking into it.

[wader]

Think i've fixed it, added pattern "#variable" for object which allows .. as {$var} like in current syntax. In both the plain object literal {$var} is ok highlight-wise but not correct jq syntax. But maybe difficult to describe a syntax where {$var} is only allowed for as but not otherwise, have to have "pattern" and "object" i guess?

[wader]

Also issue with array literals inside object literals {abc: [123, 123]} it seems, will look into it.

[wader]

Think i've fixed issue with arrays inside objects

[orentrutner]

Hey wader, thank you for taking the time to improve this extension. I'd love to just accept this change as-is. I like that it adds support for string interpolation and the foreach keyword. I also appreciate the idea of consolidating the syntax with another project that is perhaps better maintained than this one.

But I'd like to hear your thoughts about these issues:
(1) The new syntax is quite longer than the one we had. It will take me some time to read and respond.
(2) The new syntax seems to just replace the old one as-is. It might be objectively superior to the old one on all fronts. But it's not obvious from the change if some capabilities were lost when the new ones were added.
(3) The github project that the syntax was copied from doesn't appear to have a LICENSE file. We can't just copy and reuse their content (https://opensource.stackexchange.com/questions/1720/what-can-i-assume-if-a-publicly-published-project-has-no-license). Unless I'm missing the presence of a license elsewhere there, or unless the author is willing to add a license file, we can't accept the copied content.

If we can't overcome the license barrier, maybe you or I can take a look at just adding the missing features to the current syntax.

Thanks!
-Oren

[wader]

Hi,

1. No worries the original CSON syntax can be found at https://github.com/bencampion/language-jq/blob/master/grammars/jq.cson
2. Yes sorry for the messy diff :( as i commented above the CSON syntax had lot of nice things but i had to re-add some things, and i have a feeling i probably missed something. Have tried it with quite a lot of code and it seems ok.
3. As i understand the CSON syntax is under MIT https://github.com/bencampion/language-jq/blob/master/package.json#L9 but maybe it should be made clearer somehow?

[wader]

What do you think about the possibility to merge this repo and https://github.com/bencampion/language-jq somehow? not sure if it's easy to share a repo for a vscode and atom extension but would mean less work to sync syntax corrections between linguist, atom and vscode extensions.

[wader]

Hi, i've updated the syntax to use latest from https://github.com/wader/language-jq same grammar has now been merged into github linguist github-linguist/linguist#5233