Fix string interpolation hiliting#6
Open
markw65 wants to merge 1 commit into
Open
Conversation
Strings can contain arbitrary jq code, embedded between \( and ).
To fix this, we need to match the \(...) under strings.
In addition, because the arbitrary jq code could contain balanced
parentheses, we need to match those under punctuation.
Finally, since the code could also contain function calls, don't
include the opening '(' when matching a function call, so that
the parameters are handled by the newly added balanced parenthesis
code.
Author
|
Oh. Looks like there's a much more comprehensive pull request which also claims to fix this, and that one's been open for a year, so... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strings can contain arbitrary jq code, embedded between ( and ).
To fix this, we need to match the (...) under strings.
In addition, because the arbitrary jq code could contain balanced
parentheses, we need to match those under punctuation.
Finally, since the code could also contain function calls, don't
include the opening '(' when matching a function call, so that
the parameters are handled by the newly added balanced parenthesis
code.