How would I add a setting that changes the size of the canvas?

[298A-E9E3]

I've been bothered for a while now that there's no integer scaling option, so I decided I'd do it myself. I think I've figured out how to add a setting, but I'm not sure where to put code that references it. What I plan to do is make it so that if integer scaling is disabled then the canvas is the normal size, but if it's enabled, the canvas's height is set to this.gameManager.getVideoDimensions("height") * this.getSettingValue("integerScaleFactor") and the width is set to this.gameManager.getVideoDimensions("width") * this.getSettingValue("integerScaleFactor"). Where should I put this code, and how should I make it so that it doesn't mess anything else up?

[ethanaobrien]

You can just use CSS lol. The canvas will match the size of the parent element

Example: 640x480 canvas:

<div style='width:640px;height:480px;max-width:100%'>
    <div id='game'></div>
</div>

[298A-E9E3]

Yeah, I get that, but my question is where in emulatorjs's code do I put the code that actually changes the size?

[ethanaobrien]

Probably in handleResize

EmulatorJS/data/src/emulator.js

Line 4560 in d5d8d5c

handleResize() {

[298A-E9E3]

handleResize appears to be an appropriate place to put this code. The only problem is that it isn't run when the setting is changed. Is there any way for me to set a custom callback that runs whenever a specific setting changes?

[ethanaobrien]

EmulatorJS/data/src/emulator.js

Line 4715 in d5d8d5c

handleSpecialOptions(option, value) {