Fully pathed class name (including the propathed directory) not able to compile

[mjtodd95]

Had a bit of a question as to whether or not something is possible using the existing config.
We've recently moved to using this extension and vs-code and it's works great.

However we have a several classes which compile fine within mpro.
But dont compile within vs-code due to how they are defined.

Our folder structure as an example:

project/
├── objects/
│   ├── Customer.cls
│   ├── Employee.cls
│   └── util/
│       └── Common.cls
└── openedge-project.json

Customer.cls could be defined as the following:

class Customer:

But someone for example has given Employee.cls the following definition:

class objects.Employee:

And the following error occurs:

Name of the class in the CLASS statement 'objects.Employee' must match the pattern of the name of the file 'Employee.cls'. (12629)ABL Compiler(12629)

This is a snippet of how the openedge-project.json build path is configured for context:

"buildPath": [
    {
      "type": "source",
      "path": "objects",
      "build": "compiled"
    },
    {
      "type": "propath",
      "path": ".\/objects"
    }
]

Is there any way this is able to still be able to compile? Or do we need to migrate these classes to use a consistent pattern to work with the extension?

[gquerret]

You could add a source entry pointing to . (root directory of the project) but I don't recommend that, especially if you keep the objects directory as a source directory as there will be some overlap between the two entries. I'd keep the objects directory and either change the class name (and references) to match the right structure. If that implies too many changes in the source code, you can move objects/Customer.cls to objects/objects/Customer.cls. Or better, to src/objects/Customer.cls. You can have a look at the directory structure in this sample project: https://github.com/Riverside-Software/sonaroe-test-project

Extra note: your propath entry pointing to objects is not required as that's already added by the source entry

[mjtodd95]

You could add a source entry pointing to . (root directory of the project) but I don't recommend that, especially if you keep the objects directory as a source directory as there will be some overlap between the two entries. I'd keep the objects directory and either change the class name (and references) to match the right structure. If that implies too many changes in the source code, you can move objects/Customer.cls to objects/objects/Customer.cls. Or better, to src/objects/Customer.cls. You can have a look at the directory structure in this sample project: https://github.com/Riverside-Software/sonaroe-test-project

Extra note: your propath entry pointing to objects is not required as that's already added by the source entry

Thank you this was super helpful. I think the solution will end up being in the long term to migrate the class definitions and folder structures. But yeah there's a fair amount of references in some cases. There's plans in the work for upgrading our CI/CD which will require doing a lot of this type of work anyway so makes sense to tackle it then.

the source entry at '.' is interesting I'm assuming I would then need to exclude any of these classes from getting compiled by the objects source? To stop the errors? Might do us in the meantime if that would work.

[PeterJudgeCW]

the source entry at '.' is interesting I'm assuming I would then need to exclude any of these classes from getting compiled by the objects source? To stop the errors? Might do us in the meantime if that would work.

Gilles' suggestion is the better long-term solution, and will save you confusion/suffering over which classes are where and how to reference them. A consistent package (ie folder) structure is really what you should have.

That said, the build paths have options to include and/or exclude files based on Ant patterns. The project README has a few more details. So you counlt try setting the includes to only compile classes in the root folder.

{
      "type": "source",
      "path": ".",
      "includes": "*.cls",
      "excludes": ""
    }