Sync github Viewed files (backnotprop#393)

Author: rockneurotiko

apps/pi-extension/server/pr.ts

@@ -10,7 +10,9 @@ import {
 	fetchPRContext as fetchPRContextCore,
 	fetchPR as fetchPRCore,
 	fetchPRFileContent as fetchPRFileContentCore,
+	fetchPRViewedFiles as fetchPRViewedFilesCore,
 	getUser as getUserCore,
+	markPRFilesViewed as markPRFilesViewedCore,
 	type PRRef,
 	type PRReviewFileComment,
 	type PRRuntime,
@@ -89,3 +91,16 @@ export function submitPRReview(
 		fileComments,
 	);
 }
+
+export function fetchPRViewedFiles(ref: PRRef): Promise<Record<string, boolean>> {
+	return fetchPRViewedFilesCore(prRuntime, ref);
+}
+
+export function markPRFilesViewed(
+	ref: PRRef,
+	prNodeId: string,
+	filePaths: string[],
+	viewed: boolean,
+): Promise<void> {
+	return markPRFilesViewedCore(prRuntime, ref, prNodeId, filePaths, viewed);
+}

apps/pi-extension/server/serverReview.ts

@@ -47,7 +47,9 @@ import { listenOnPort } from "./network.js";
 import {
 	fetchPRContext,
 	fetchPRFileContent,
+	fetchPRViewedFiles,
 	getPRUser,
+	markPRFilesViewed,
 	submitPRReview,
 } from "./pr.js";
 import { getRepoInfo } from "./project.js";
@@ -119,6 +121,19 @@ export async function startReviewServer(options: {
 	const isPRMode = !!prMeta;
 	const prRef = prMeta ? prRefFromMetadata(prMeta) : null;
 	const platformUser = prRef ? await getPRUser(prRef) : null;
+
+	// Fetch GitHub viewed file state (non-blocking — errors are silently ignored)
+	let initialViewedFiles: string[] = [];
+	if (isPRMode && prRef) {
+		try {
+			const viewedMap = await fetchPRViewedFiles(prRef);
+			initialViewedFiles = Object.entries(viewedMap)
+				.filter(([, isViewed]) => isViewed)
+				.map(([path]) => path);
+		} catch {
+			// Non-fatal: viewed state is best-effort
+		}
+	}
 	const repoInfo = prMeta
 		? {
 				display: getDisplayRepo(prMeta),
@@ -280,6 +295,7 @@ export async function startReviewServer(options: {
 				shareBaseUrl,
 				repoInfo,
 				...(isPRMode && { prMetadata: prMeta, platformUser }),
+				...(isPRMode && initialViewedFiles.length > 0 && { viewedFiles: initialViewedFiles }),
 				...(currentError ? { error: currentError } : {}),
 			});
 		} else if (url.pathname === "/api/diff/switch" && req.method === "POST") {
@@ -354,6 +370,39 @@ export async function startReviewServer(options: {
 					500,
 				);
 			}
+		} else if (url.pathname === "/api/pr-viewed" && req.method === "POST") {
+			if (!isPRMode || !prMeta || !prRef) {
+				json(res, { error: "Not in PR mode" }, 400);
+				return;
+			}
+			if (prMeta.platform !== "github") {
+				json(res, { error: "Viewed sync only supported for GitHub" }, 400);
+				return;
+			}
+			const prNodeId = prMeta.prNodeId;
+			if (!prNodeId) {
+				json(res, { error: "PR node ID not available" }, 400);
+				return;
+			}
+			try {
+				const body = await parseBody(req);
+				await markPRFilesViewed(
+					prRef,
+					prNodeId,
+					body.filePaths as string[],
+					body.viewed as boolean,
+				);
+				json(res, { ok: true });
+			} catch (err) {
+				json(
+					res,
+					{
+						error:
+							err instanceof Error ? err.message : "Failed to update viewed state",
+					},
+					500,
+				);
+			}
 		} else if (url.pathname === "/api/file-content" && req.method === "GET") {
 			const filePath = url.searchParams.get("path");
 			if (!filePath) {

bun.lock

@@ -387,6 +387,7 @@ const ReviewApp: React.FC = () => {
         repoInfo?: { display: string; branch?: string };
         prMetadata?: PRMetadata;
         platformUser?: string;
+        viewedFiles?: string[];
         error?: string;
         isWSL?: boolean;
       }) => {
@@ -408,6 +409,10 @@ const ReviewApp: React.FC = () => {
         if (data.repoInfo) setRepoInfo(data.repoInfo);
         if (data.prMetadata) setPrMetadata(data.prMetadata);
         if (data.platformUser) setPlatformUser(data.platformUser);
+        // Initialize viewed files from GitHub's state (set before draft restore so draft takes precedence)
+        if (data.viewedFiles && data.viewedFiles.length > 0) {
+          setViewedFiles(new Set(data.viewedFiles));
+        }
         if (data.error) setDiffError(data.error);
         if (data.isWSL) setIsWSL(true);
       })
@@ -531,14 +536,26 @@ const ReviewApp: React.FC = () => {
   const handleToggleViewed = useCallback((filePath: string) => {
     setViewedFiles(prev => {
       const next = new Set(prev);
-      if (next.has(filePath)) {
-        next.delete(filePath);
-      } else {
+      const willBeViewed = !prev.has(filePath);
+      if (willBeViewed) {
         next.add(filePath);
+      } else {
+        next.delete(filePath);
+      }
+      // Sync viewed state to GitHub (fire and forget — best effort)
+      // Capture willBeViewed inside the callback to ensure correctness with React batching
+      if (prMetadata && prMetadata.platform === 'github') {
+        fetch('/api/pr-viewed', {
+          method: 'POST',
+          headers: { 'Content-Type': 'application/json' },
+          body: JSON.stringify({ filePaths: [filePath], viewed: willBeViewed }),
+        }).catch(() => {
+          // Silently ignore — viewed sync is best-effort
+        });
       }
       return next;
     });
-  }, []);
+  }, [prMetadata]);
 
   // Derive worktree path and base diff type from the composite diffType string
   const { activeWorktreePath, activeDiffBase } = useMemo(() => {

packages/review-editor/App.tsx

@@ -18,6 +18,8 @@ import {
   fetchPRContext as fetchPRContextCore,
   fetchPRFileContent as fetchPRFileContentCore,
   submitPRReview as submitPRReviewCore,
+  fetchPRViewedFiles as fetchPRViewedFilesCore,
+  markPRFilesViewed as markPRFilesViewedCore,
   prRefFromMetadata,
   getPlatformLabel,
   getMRLabel,
@@ -29,6 +31,7 @@ import {
 
 export type { PRRef, PRMetadata, PRContext, PRReviewFileComment } from "@plannotator/shared/pr-provider";
 export { prRefFromMetadata, getPlatformLabel, getMRLabel, getMRNumberLabel, getDisplayRepo, getCliName, getCliInstallUrl } from "@plannotator/shared/pr-provider";
+export type { GithubPRMetadata } from "@plannotator/shared/pr-provider";
 
 const runtime: PRRuntime = {
   async runCommand(cmd, args) {
@@ -105,3 +108,18 @@ export function submitPRReview(
 ): Promise<void> {
   return submitPRReviewCore(runtime, ref, headSha, action, body, fileComments);
 }
+
+export function fetchPRViewedFiles(
+  ref: PRRef,
+): Promise<Record<string, boolean>> {
+  return fetchPRViewedFilesCore(runtime, ref);
+}
+
+export function markPRFilesViewed(
+  ref: PRRef,
+  prNodeId: string,
+  filePaths: string[],
+  viewed: boolean,
+): Promise<void> {
+  return markPRFilesViewedCore(runtime, ref, prNodeId, filePaths, viewed);
+}

packages/server/pr.ts

@@ -15,7 +15,7 @@ import { getRepoInfo } from "./repo";
 import { handleImage, handleUpload, handleAgents, handleServerReady, handleDraftSave, handleDraftLoad, handleDraftDelete, handleFavicon, type OpencodeClient } from "./shared-handlers";
 import { contentHash, deleteDraft } from "./draft";
 import { createEditorAnnotationHandler } from "./editor-annotations";
-import { type PRMetadata, type PRReviewFileComment, fetchPRFileContent, fetchPRContext, submitPRReview, getPRUser, prRefFromMetadata, getDisplayRepo, getMRLabel, getMRNumberLabel } from "./pr";
+import { type PRMetadata, type PRReviewFileComment, fetchPRFileContent, fetchPRContext, submitPRReview, fetchPRViewedFiles, markPRFilesViewed, getPRUser, prRefFromMetadata, getDisplayRepo, getMRLabel, getMRNumberLabel } from "./pr";
 import { createAIEndpoints, ProviderRegistry, SessionManager, createProvider, type AIEndpoints, type PiSDKConfig } from "@plannotator/ai";
 import { isWSL } from "./browser";
 
@@ -202,6 +202,23 @@ export async function startReviewServer(
   const prRef = isPRMode ? prRefFromMetadata(prMetadata) : null;
   const platformUser = prRef ? await getPRUser(prRef) : null;
 
+  // Fetch GitHub viewed file state (non-blocking — errors are silently ignored)
+  let initialViewedFiles: string[] = [];
+  if (isPRMode && prRef) {
+    console.log("[plannotator] Fetching PR viewed files for", prRef);
+    try {
+      const viewedMap = await fetchPRViewedFiles(prRef);
+      console.log("[plannotator] PR viewed files map:", viewedMap);
+      initialViewedFiles = Object.entries(viewedMap)
+        .filter(([, isViewed]) => isViewed)
+        .map(([path]) => path);
+      console.log("[plannotator] Initial viewed files:", initialViewedFiles);
+    } catch (err) {
+      // Non-fatal: viewed state is best-effort
+      console.warn("[plannotator] Could not fetch PR viewed files:", err instanceof Error ? err.message : err);
+    }
+  }
+
   // Decision promise
   let resolveDecision: (result: {
     approved: boolean;
@@ -242,6 +259,7 @@ export async function startReviewServer(
               repoInfo,
               isWSL: wslFlag,
               ...(isPRMode && { prMetadata, platformUser }),
+              ...(isPRMode && initialViewedFiles.length > 0 && { viewedFiles: initialViewedFiles }),
               ...(currentError && { error: currentError }),
             });
           }
@@ -462,6 +480,38 @@ export async function startReviewServer(
             }
           }
 
+          // API: Mark/unmark PR files as viewed on GitHub (PR mode, GitHub only)
+          if (url.pathname === "/api/pr-viewed" && req.method === "POST") {
+            if (!isPRMode || !prMetadata) {
+              console.log("[plannotator] /api/pr-viewed: not in PR mode");
+              return Response.json({ error: "Not in PR mode" }, { status: 400 });
+            }
+            if (prMetadata.platform !== "github") {
+              console.log("[plannotator] /api/pr-viewed: platform is", prMetadata.platform, "(not github)");
+              return Response.json({ error: "Viewed sync only supported for GitHub" }, { status: 400 });
+            }
+            const prNodeId = prMetadata.prNodeId;
+            if (!prNodeId) {
+              console.log("[plannotator] /api/pr-viewed: prNodeId missing from metadata:", prMetadata);
+              return Response.json({ error: "PR node ID not available" }, { status: 400 });
+            }
+            try {
+              const body = (await req.json()) as {
+                filePaths: string[];
+                viewed: boolean;
+              };
+              console.log("[plannotator] /api/pr-viewed: marking", body.filePaths, "as viewed=", body.viewed, "prNodeId=", prNodeId);
+              await markPRFilesViewed(prRef!, prNodeId, body.filePaths, body.viewed);
+              console.log("[plannotator] /api/pr-viewed: success");
+              return Response.json({ ok: true });
+            } catch (err) {
+              const message =
+                err instanceof Error ? err.message : "Failed to update viewed state";
+              console.error("[plannotator] /api/pr-viewed error:", message);
+              return Response.json({ error: message }, { status: 500 });
+            }
+          }
+
           // AI endpoints
           if (aiEndpoints && url.pathname.startsWith("/api/ai/")) {
             const handler = aiEndpoints[url.pathname as keyof AIEndpoints];