updated deps, removed rustls-tls because that feature no longer exist…#7
updated deps, removed rustls-tls because that feature no longer exist…#7Havunen wants to merge 1 commit into
Conversation
|
|
📝 WalkthroughWalkthroughThis PR updates ChangesDependency Updates and Feature Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Cargo.toml`:
- Around line 18-20: Add a breaking-change note to the project docs explaining
that the rustls-tls feature was removed: update the changelog or add a migration
guide stating that the rustls-tls feature is no longer available, that removal
was necessary because reqwest dropped support for rustls, and provide migration
instructions telling users to either keep using native-tls (the default feature
name native-tls) or to configure TLS via reqwest feature flags (reference
reqwest) or external TLS configuration; mention the commit (0aca9d9) as the
change origin and include example guidance on how to alter their Cargo.toml
feature selection accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 05da03aa-1c9d-44a8-afd0-d31be40385da
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
| [features] | ||
| default = ["native-tls"] | ||
| native-tls = ["reqwest/native-tls"] |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find references to rustls-tls feature in docs and code
echo "Checking README and documentation..."
fd -e md -e txt -e rst --exec rg -l "rustls" {}
echo "Checking for rustls-tls in feature gates..."
rg "cfg.*feature.*rustls" --type rust -C3
echo "Checking examples and tests..."
fd "example|test" --type d --exec rg -l "rustls" {}Repository: ory/client-rust
Length of output: 171
🏁 Script executed:
#!/bin/bash
# Find changelog and migration documentation
echo "=== Looking for changelog files ==="
fd -type f \( -name "*CHANGE*" -o -name "*HISTORY*" -o -name "*MIGRATION*" -o -name "*RELEASE*" \) | head -20
echo ""
echo "=== Checking full Cargo.toml content ==="
cat Cargo.toml
echo ""
echo "=== Searching for any rustls mentions in all files ==="
rg "rustls" --no-heading -i
echo ""
echo "=== Checking for comments about feature removal ==="
rg "feature.*remov" --type rust -i -C2Repository: ory/client-rust
Length of output: 1120
🏁 Script executed:
#!/bin/bash
# Check git history for rustls and feature changes
echo "=== Git log for Cargo.toml (last 20 commits) ==="
git log --oneline -20 Cargo.toml
echo ""
echo "=== Full history of [features] section in Cargo.toml ==="
git log -p Cargo.toml | grep -A5 -B5 "\[features\]" | head -80Repository: ory/client-rust
Length of output: 255
Document the rustls-tls feature removal as a breaking change.
The rustls-tls feature has been removed from this crate (commit 0aca9d9) because the underlying reqwest crate no longer supports it. The code removal is clean with no dangling references. However, there is no changelog or migration guide explaining this breaking change to users. Users upgrading to this version will encounter build failures without clear guidance.
Add documentation (CHANGELOG.md or migration guide) explaining:
- The rustls-tls feature has been removed
- Why (reqwest deprecated the feature)
- Migration path: Users should either use native-tls or configure TLS externally via reqwest's feature flags
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Cargo.toml` around lines 18 - 20, Add a breaking-change note to the project
docs explaining that the rustls-tls feature was removed: update the changelog or
add a migration guide stating that the rustls-tls feature is no longer
available, that removal was necessary because reqwest dropped support for
rustls, and provide migration instructions telling users to either keep using
native-tls (the default feature name native-tls) or to configure TLS via reqwest
feature flags (reference reqwest) or external TLS configuration; mention the
commit (0aca9d9) as the change origin and include example guidance on how to
alter their Cargo.toml feature selection accordingly.
2 participants
… in reqwest
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
Further comments
Summary by CodeRabbit