PART 2: refactor: leverage polymorphism for unauthenticated access fallback - After #7331#7358
Draft
okurz wants to merge 1 commit into
Draft
PART 2: refactor: leverage polymorphism for unauthenticated access fallback - After #7331#7358okurz wants to merge 1 commit into
okurz wants to merge 1 commit into
Conversation
okurz
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7358 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 419 419
Lines 44504 44504
===========================================
- Hits 44504 44501 -3
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
okurz
force-pushed
the
feature/084_none_auth_bootstrap_2
branch
from
c47ff15 to
b5109cf
Compare
Motivation: Avoid hardcoding specific authentication methods like 'None' in core controllers and helpers. Design Choices: - Introduced 'unauthenticated_user' method in Auth providers. - Updated Auth controller and SharedHelpers to use this method if present. - Moved 'admin' user auto-login logic for 'None' provider into the None.pm module. Benefits: Cleaner code, better maintainability, and easier to add future providers with similar unauthenticated access needs.
okurz
force-pushed
the
feature/084_none_auth_bootstrap_2
branch
from
b5109cf to
7d895ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Avoid hardcoding specific authentication methods like 'None' in core
controllers and helpers.
Design Choices:
present.
None.pm module.
Benefits:
Cleaner code, better maintainability, and easier to add future providers
with similar unauthenticated access needs.
After: