PART 1: Add dependencies for modern Python development#505
Conversation
okurz
commented
Jan 8, 2026
- feat(ci): Simplify deps setup with uv
- feat(pyproject.toml): Add config for proper python package paths
- feat(Makefile): Add more Python related targets using "uv"
- feat(pyproject.toml): Add dependencies in preparation for typecheck+maintainability checks
- feat(pyproject.toml): Enable dependencies for modern scripts (typer+httpx)
- fix(test_trigger_bisect_jobs): fix "path" style issue
d914509 to
e392ac5
Compare
Martchus
left a comment
There was a problem hiding this comment.
Are these dependencies already required? If not I wouldn't separate adding them from the actual changes requiring them.
| - uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| enable-cache: true | ||
| - run: uv sync |
There was a problem hiding this comment.
I would expect to find also uv.lock in the repo. otherwise what the us is syncing?
There was a problem hiding this comment.
same is in https://github.com/openSUSE/qem-bot/blob/master/.github/workflows/ci.yml#L22 this installs all necessary dependencies
There was a problem hiding this comment.
which also doesnt have a uv.lock. which means that it creates a new one each time is run likely. Both repos should contain the uv.lock. Then the ci should see this and run exactly the same as you run in your workstation
There was a problem hiding this comment.
I think so as well, uv.lock is necessary for reproducible Python environments.
the dependencies would only be required in #499 |
Martchus
left a comment
There was a problem hiding this comment.
Then I say we should add the dependencies only as needed. At least for me it makes no sense to approve this independently from the actual code that I haven't looked at.
e392ac5 to
70d2328
Compare
70d2328 to
8c3b874
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
8c3b874 to
53e75e8
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
53e75e8 to
d3e8180
Compare