feat: add support for AbortController signal in writeFile#216
Open
Dorosty wants to merge 1 commit into
Open
Conversation
Member
|
@andersevenrud with a squash and merge so we can use the correct commit message syntax, I see no problems with this one. Thoughts? |
Member
|
Looks OK to me
…On Sat, 29 Jun 2024, 16:10 Aaron Meese, ***@***.***> wrote:
@andersevenrud <https://github.com/andersevenrud> with a squash and merge
so we can use the correct commit message syntax, I see no problems with
this one. Thoughts?
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHODFP25QJOEH22KR5WETZJ255PAVCNFSM6AAAAABFQ3TAQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGIYDQMBUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ajmeese7
approved these changes
Jun 29, 2024
Member
|
I was looking at merging your work, but I had to refresh my memory a little bit, and there are two ways uploads are handled: osjs-client/src/utils/fetch.js Lines 157 to 159 in 12717e2 The XHR method is used when there's need to track the upload progression. The Or maybe you guys have some better ideas ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os-js/osjs-filemanager-application#44 (comment)