Skip to content

Commit 1acdadd

Browse files
authored
Merge pull request #383 from os2display/feature/fix-playlist-slide-unlink-test
Fix testUnlinkSlide finding same slide twice
2 parents 50073e0 + beb1f90 commit 1acdadd

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
- [#383](https://github.com/os2display/display-api-service/pull/383)
8+
- Fixed `testUnlinkSlide` using same slide for both lookups, causing "Relation not found" failure.
79
- [#379](https://github.com/os2display/display-api-service/pull/379)
810
- Ensure the http client has a default time out setting. Make it configurable in env.
911
- [#376](https://github.com/os2display/display-api-service/pull/376)

tests/Api/PlaylistSlideTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,9 @@ public function testUnlinkSlide(): void
158158
$iri = $this->findIriBy(Playlist::class, ['tenant' => $this->tenant]);
159159
$playlistUlid = $this->iriHelperUtils->getUlidFromIRI($iri);
160160

161-
$iri = $this->findIriBy(Slide::class, ['tenant' => $this->tenant]);
161+
$iri = $this->findIriBy(Slide::class, ['tenant' => $this->tenant, 'title' => 'slide_abc_2']);
162162
$slideUlid1 = $this->iriHelperUtils->getUlidFromIRI($iri);
163-
$iri = $this->findIriBy(Slide::class, ['tenant' => $this->tenant]);
163+
$iri = $this->findIriBy(Slide::class, ['tenant' => $this->tenant, 'title' => 'slide_abc_3']);
164164
$slideUlid2 = $this->iriHelperUtils->getUlidFromIRI($iri);
165165

166166
// First create relations to ensure they exist before deleting theme.

0 commit comments

Comments
 (0)