feat(logging): PHPStan logging gate + silent-catch migration

Add three project-local PHPStan rules (ADR 011 / docs/logging.md) and
resolve every site they flag in the same change — zero baseline entries:

- NoSilentCatchRule (logging.silentCatch): flags a catch that neither
  rethrows, logs via PSR-3, calls error_log/trigger_error, nor reports the
  failure to the console (SymfonyStyle/OutputInterface). The console-output
  exemption is in the rule, not a src/Command/ path exclusion, so a genuinely
  empty catch in a command (unattended cron/Messenger) is still flagged.
- NoInterpolatedLogMessageRule (logging.interpolatedLogMessage): log message
  must be a static string; variable data goes in the context array.
- ExceptionInContextMustUseExceptionKeyRule (logging.exceptionContextKey): a
  Throwable in the context array must use the "exception" key.

Silent-catch migration: inject channel-bound loggers and log the swallowed
exception (AuthOidc/AuthScreenBind, ColiboFeedType, InstantBook, FeedService,
Feed/Theme/UserProvider), convert interpolated feed-type messages to static
message + exception context, and annotate the genuinely-intentional silences
(optional OIDC end-session URL, per-booking time parse, read-degradation in
FeedSourceProvider, the log-enrichment guard, validator violation, fixtures).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: turegjorup

CHANGELOG.md

@@ -29,6 +29,10 @@ All notable changes to this project will be documented in this file.
   The HTTP client now logs completed requests at `info` and failures at `error` on the
   `outbound_http` channel, thresholded by the new `LOG_LEVEL_OUTBOUND_HTTP` like every
   other channel; the `HTTP_CLIENT_LOG_LEVEL` env var is removed (use `LOG_LEVEL_OUTBOUND_HTTP`).
+- Enforced the logging conventions in CI with three project-local PHPStan rules
+  (`logging.silentCatch`, `logging.interpolatedLogMessage`, `logging.exceptionContextKey`) and
+  migrated the previously silent catch sites to log the exception, surface it, or be explicitly
+  annotated as intentional.
 - Removed the deprecated feed types `SparkleIOFeedType`, `EventDatabaseApiFeedType` and `KobaFeedType`.
   Made the unknown-feed-type handling consistent: **reads degrade, writes are rejected.** Feed sources
   (and feeds) that reference a removed type keep loading — item and collection reads return them with no

config/services.yaml

@@ -87,6 +87,27 @@ services:
         arguments:
             $logger: '@monolog.logger.auth'
 
+    # Channel-bound loggers for classes that log failures (ADR 011 / docs/logging.md).
+    App\Controller\Api\AuthOidcController:
+        arguments:
+            $logger: '@monolog.logger.auth'
+
+    App\Controller\Api\AuthScreenBindController:
+        arguments:
+            $logger: '@monolog.logger.screen'
+
+    App\Feed\ColiboFeedType:
+        arguments:
+            $logger: '@monolog.logger.feed'
+
+    App\Feed\NotifiedFeedType:
+        arguments:
+            $logger: '@monolog.logger.feed'
+
+    App\Feed\RssFeedType:
+        arguments:
+            $logger: '@monolog.logger.feed'
+
     Symfony\Component\Security\Http\Authentication\AuthenticationFailureHandlerInterface: '@Lexik\Bundle\JWTAuthenticationBundle\Security\Http\Authentication\AuthenticationFailureHandler'
     Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface: '@Lexik\Bundle\JWTAuthenticationBundle\Security\Http\Authentication\AuthenticationSuccessHandler'
 
@@ -137,6 +158,7 @@ services:
     App\InteractiveSlide\InstantBook:
         arguments:
             $busyIntervalsSource: '%env(string:INSTANT_BOOK_BUSY_INTERVALS_SOURCE)%'
+            $logger: '@monolog.logger.interactive'
 
     App\Service\KeyVaultService:
         arguments:
@@ -182,7 +204,8 @@ services:
 
     App\Service\FeedService:
         arguments:
-            - !tagged_iterator app.feed.feed_type
+            $feedTypes: !tagged_iterator app.feed.feed_type
+            $logger: '@monolog.logger.feed'
 
     App\Service\InteractiveSlideService:
         arguments:
@@ -308,6 +331,7 @@ services:
         tags: [{ name: 'api_platform.state_provider', priority: 2 }]
         arguments:
             $itemExtensions: !tagged_iterator api_platform.doctrine.orm.query_extension.item
+            $logger: '@monolog.logger.feed'
 
     # https://api-platform.com/docs/v2.7/core/state-providers/
     App\State\MediaProvider:

phpstan.dist.neon

@@ -13,3 +13,7 @@ rules:
     # Forbids `$this->addSql(...)` in any file under `migrations/`.
     # Future migrations must use Doctrine's Schema tool API for portability.
     - App\PhpStan\NoAddSqlInMigrationRule
+    # Structured-logging conventions (ADR 011 / docs/logging.md).
+    - App\PhpStan\NoSilentCatchRule
+    - App\PhpStan\NoInterpolatedLogMessageRule
+    - App\PhpStan\ExceptionInContextMustUseExceptionKeyRule

src/Controller/Api/AuthOidcController.php

@@ -10,6 +10,7 @@
 use ItkDev\OpenIdConnectBundle\Security\OpenIdConfigurationProviderManager;
 use Lexik\Bundle\JWTAuthenticationBundle\Security\Http\Authentication\AuthenticationFailureHandler;
 use Lexik\Bundle\JWTAuthenticationBundle\Security\Http\Authentication\AuthenticationSuccessHandler;
+use Psr\Log\LoggerInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
@@ -28,6 +29,7 @@ public function __construct(
         private readonly AzureOidcAuthenticator $oidcAuthenticator,
         private readonly AuthenticationSuccessHandler $successHandler,
         private readonly AuthenticationFailureHandler $failureHandler,
+        private readonly LoggerInterface $logger,
     ) {}
 
     #[Route('/v2/authentication/oidc/token', name: 'authentication_oidc_token', methods: ['GET'])]
@@ -39,6 +41,8 @@ public function getToken(Request $request): Response
 
                 return $this->successHandler->handleAuthenticationSuccess($passport->getUser());
             } catch (CustomUserMessageAuthenticationException|InvalidProviderException $e) {
+                $this->logger->warning('OIDC token authentication failed', ['exception' => $e]);
+
                 $e = new AuthenticationException($e->getMessage());
 
                 return $this->failureHandler->onAuthenticationFailure($request, $e);
@@ -75,7 +79,7 @@ public function getUrls(Request $request): Response
             // We allow end session endpoint to not be set.
             try {
                 $endSessionUrl = $provider->getEndSessionUrl();
-            } catch (OpenIdConnectExceptionInterface) {
+            } catch (OpenIdConnectExceptionInterface) { // @phpstan-ignore logging.silentCatch (the end-session endpoint is optional; its absence is an expected configuration, not a failure)
                 $endSessionUrl = null;
             }
 

src/Controller/Api/AuthScreenBindController.php

@@ -9,6 +9,7 @@
 use App\Security\ScreenAuthenticator;
 use App\Utils\ValidationUtils;
 use Psr\Cache\InvalidArgumentException;
+use Psr\Log\LoggerInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
@@ -22,6 +23,7 @@ public function __construct(
         private readonly ScreenAuthenticator $authScreenService,
         private readonly ValidationUtils $validationUtils,
         private readonly ScreenRepository $screenRepository,
+        private readonly LoggerInterface $logger,
     ) {}
 
     public function __invoke(Request $request, string $id): Response
@@ -42,7 +44,9 @@ public function __invoke(Request $request, string $id): Response
 
         try {
             $this->authScreenService->bindScreen($screen, $bindKey);
-        } catch (\Exception|InvalidArgumentException) {
+        } catch (\Exception|InvalidArgumentException $e) {
+            $this->logger->error('Screen bind failed', ['exception' => $e, 'screen_id' => (string) $screenUlid]);
+
             return new JsonResponse('Key not accepted', Response::HTTP_BAD_REQUEST);
         }
 

src/DataFixtures/Faker/Provider/RRuleProvider.php

@@ -36,7 +36,7 @@ public static function rrule(): ?RRuleInterface
                 'count' => $faker->numberBetween(1, 20),
                 'dtstart' => $faker->dateTimeBetween('now', '+10 weeks'),
             ]);
-        } catch (\Exception $exception) {
+        } catch (\Exception $exception) { // @phpstan-ignore logging.silentCatch (dev-only fixture provider; exit() prints the message and aborts the fixtures load)
             exit($exception->getMessage());
         }
 

src/Feed/BrndFeedType.php

@@ -166,7 +166,7 @@ private function parseBrndBooking(array $booking): array
                 if (false === $startDateTime) {
                     $startDateTime = null;
                 }
-            } catch (\ValueError) {
+            } catch (\ValueError) { // @phpstan-ignore logging.silentCatch (a malformed/unparseable start time is an expected per-booking data condition; null is a valid value for the optional field)
                 $startDateTime = null;
             }
         }
@@ -182,7 +182,7 @@ private function parseBrndBooking(array $booking): array
                 if (false === $endDateTime) {
                     $endDateTime = null;
                 }
-            } catch (\ValueError) {
+            } catch (\ValueError) { // @phpstan-ignore logging.silentCatch (a malformed/unparseable end time is an expected per-booking data condition; null is a valid value for the optional field)
                 $endDateTime = null;
             }
         }

src/Feed/ColiboFeedType.php

@@ -14,6 +14,7 @@
 use FeedIo\Feed\Node\Category;
 use Psr\Cache\CacheItemInterface;
 use Psr\Cache\CacheItemPoolInterface;
+use Psr\Log\LoggerInterface;
 use Symfony\Component\DomCrawler\Crawler;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\Uid\Ulid;
@@ -34,6 +35,7 @@ public function __construct(
         private readonly FeedService $feedService,
         private readonly ApiClient $apiClient,
         private readonly CacheItemPoolInterface $feedsCache,
+        private readonly LoggerInterface $logger,
     ) {}
 
     public function getAdminFormOptions(FeedSource $feedSource): array
@@ -133,7 +135,8 @@ public function getData(Feed $feed): array
             if (null !== $entry->fields->galleryItems) {
                 try {
                     $galleryItems = json_decode($entry->fields->galleryItems, true, 512, JSON_THROW_ON_ERROR);
-                } catch (\JsonException) {
+                } catch (\JsonException $e) {
+                    $this->logger->warning('Malformed gallery items in Colibo feed entry', ['exception' => $e]);
                     $galleryItems = [];
                 }
 

src/Feed/NotifiedFeedType.php

@@ -59,7 +59,7 @@ public function getData(Feed $feed): array
             try {
                 $mentions = $this->getMentions($token, 1, $pageSize, $configuration['feeds']);
             } catch (\Throwable $throwable) {
-                $this->logger->error("NotifiedFeedType: Failed to get mentions: {$throwable->getMessage()}");
+                $this->logger->error('Failed to get mentions', ['exception' => $throwable]);
             }
 
             $result = [];
@@ -77,7 +77,7 @@ public function getData(Feed $feed): array
                 try {
                     $response = $this->client->request(Request::METHOD_HEAD, $mediaUrl);
                 } catch (\Throwable $throwable) {
-                    $this->logger->error("NotifiedFeedType: Failed to get mediaUrl: {$throwable->getMessage()}");
+                    $this->logger->error('Failed to fetch media URL', ['exception' => $throwable, 'media_url' => $mediaUrl]);
                     continue;
                 }
 

src/Feed/RssFeedType.php

@@ -73,7 +73,7 @@ public function getData(Feed $feed): array
 
             return $result;
         } catch (\Throwable $throwable) {
-            $this->logger->error($throwable->getCode().': '.$throwable->getMessage());
+            $this->logger->error('RSS feed processing failed', ['exception' => $throwable]);
 
             throw $throwable;
         }