Merge pull request #485 from os2display/feature/fix-media-repository-undefined-vars

fix: remove dead statement referencing undefined variables in MediaRepository

Author: turegjorup

CHANGELOG.md

@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+- Removed a dead statement in `MediaRepository::getPaginator()` that referenced the undefined
+  variables `$page` and `$itemsPerPage`; the computed value was never used.
 - Fixed inverted user-type guard in `UserService::activateExternalUser()`: the "user is not of
   external type" check could never trigger due to a stray negation (`=== !$user->getUserType()`).
   The endpoint was still protected by `ExternalUserAuthenticator`, so this restores the intended

phpstan-baseline.neon

@@ -2112,18 +2112,6 @@ parameters:
 			count: 1
 			path: src/Repository/MediaRepository.php
 
-		-
-			message: '#^Undefined variable\: \$itemsPerPage$#'
-			identifier: variable.undefined
-			count: 1
-			path: src/Repository/MediaRepository.php
-
-		-
-			message: '#^Undefined variable\: \$page$#'
-			identifier: variable.undefined
-			count: 1
-			path: src/Repository/MediaRepository.php
-
 		-
 			message: '#^Class App\\Repository\\PlaylistRepository has PHPDoc tag @method for method findBy\(\) parameter \#1 \$criteria with no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue

src/Repository/MediaRepository.php

@@ -40,8 +40,6 @@ public function getById(Ulid $mediaId): QueryBuilder
 
     public function getPaginator(Ulid $slideUlid): QueryBuilder
     {
-        $firstResult = ($page - 1) * $itemsPerPage;
-
         $queryBuilder = $this->_em->createQueryBuilder();
         $queryBuilder->select('s')
             ->from(Slide::class, 's')