Skip to content

Commit de03309

Browse files
authored
Merge pull request #489 from os2display/chore/rename-test-frontend-built-script
docs(test): rename Playwright build-test script and tighten README
2 parents 1cc39d1 + 94f39f3 commit de03309

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

.claude/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"Bash(docker compose:*)",
1313
"WebFetch(domain:api-platform.com)",
1414
"Bash(grep:*)",
15-
"Bash(./scripts/test *)",
15+
"Bash(./scripts/test-frontend-built.sh *)",
1616
"Bash(git add:*)",
1717
"Bash(git fetch*)",
1818
"Bash(git pull*)",

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -453,9 +453,9 @@ See the `docker-compose.yml` playwright entry and the version imported in packag
453453

454454
#### Testing on the built files
455455

456-
This project includes a test script that handles building assets, running
457-
Playwright tests, and stops and starts the node container. This script tests the
458-
*built* files. This is the approach the GitHub Action uses.
456+
Runs the Playwright end-to-end suite against a production build: it stops the
457+
`node` (Vite dev) container, builds the assets, runs the tests, then restarts
458+
`node`the same flow the CI Playwright job uses.
459459

460460
```shell
461461
task test:frontend-built
@@ -464,7 +464,7 @@ task test:frontend-built
464464
or
465465

466466
```shell
467-
./scripts/test {TEST-PATH}
467+
./scripts/test-frontend-built.sh {TEST-PATH}
468468
```
469469

470470
TEST-PATH is optional, and is the specific test file or directory to run like

Taskfile.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ tasks:
236236
test:frontend-built:
237237
desc: "Runs frontend tests (Playwright) on the built files. This temporarily stops the node container."
238238
cmds:
239-
- ./scripts/test
239+
- ./scripts/test-frontend-built.sh
240240

241241
test:frontend-local:
242242
desc: "Runs frontend tests from the local machine."

0 commit comments

Comments
 (0)