Skip to content

Commit df5fdb8

Browse files
authored
Merge pull request #429 from os2display/feature/release-workflow-node-permissions
Fix Create Github Release workflow node_modules permissions
2 parents c6296af + 1ce6a32 commit df5fdb8

4 files changed

Lines changed: 10 additions & 3 deletions

File tree

.dockerignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
# CI / quality-tool configs (not consumed at runtime)
2828
/phpstan.dist.neon
29+
/phpstan-baseline.neon
2930
/phpunit.xml.dist
3031
/psalm.xml
3132
/psalm-baseline.xml
@@ -65,7 +66,7 @@ launch.json
6566
/test-results/
6667
/playwright-report/
6768
/blob-report/
68-
/playwright/.cache/
69+
/playwright/
6970
#< Playwright
7071

7172
###> vincentlanglet/twig-cs-fixer ###

.github/workflows/github_build_release.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,13 @@ jobs:
3838
composer install --no-dev -o --classmap-authoritative
3939
docker compose run --rm --env APP_ENV=prod phpfpm composer clear-cache
4040
41+
- name: Set compose node user
42+
run: echo "COMPOSE_NODE_USER=$(id -u):$(id -g)" >> "$GITHUB_ENV"
43+
4144
- name: NPM install and build
4245
run: |
43-
docker compose run --rm node npm install
44-
docker compose run --rm node npm run build
46+
docker compose run --rm --env HOME=/tmp node npm install
47+
docker compose run --rm --env HOME=/tmp node npm run build
4548
4649
- name: Cleanup before packaging
4750
run: |

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
- Fixed `Create Github Release` workflow that failed cleanup because `node_modules/` was owned by root.
8+
79
## [3.0.0-rc1] - 2026-05-04
810

911
- Cleaned up and documented CI workflows; api-spec workflow now reports breaking changes.

docker-compose.override.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ services:
1515

1616
node:
1717
image: node:24
18+
user: "${COMPOSE_NODE_USER:-root}"
1819
command: npm run dev
1920
networks:
2021
- app

0 commit comments

Comments
 (0)