Skip to content

Commit ffc34eb

Browse files
authored
Merge pull request #474 from os2display/feature/openid-connect-bundle-5
chore(deps): upgrade itk-dev/openid-connect-bundle to 5.0
2 parents 89ba611 + 73cee14 commit ffc34eb

10 files changed

Lines changed: 566 additions & 64 deletions

File tree

.env

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,11 @@ RELATIONS_CHECKSUM_ENABLED=true
146146

147147
###> itk-dev/openid-connect-bundle ###
148148
# See docs/feed/openid-connect.md for variable explanations.
149+
# Total HTTP request timeout (seconds) for calls to the OIDC providers
150+
# (discovery, JWKS, token exchange). Bounds a hung/slow IdP so it cannot
151+
# tie up a php-fpm worker indefinitely. Applies to both providers.
152+
OIDC_HTTP_TIMEOUT=5
153+
149154
# internal provider (admin login)
150155
# URL to OIDC provider's metadata/discovery endpoint.
151156
INTERNAL_OIDC_METADATA_URL=INTERNAL_OIDC_METADATA_URL

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
- Upgraded `itk-dev/openid-connect-bundle` to 5.0 (and `itk-dev/openid-connect` to 5.0). Migrated the
8+
OIDC exception catches in `AuthOidcController` and `AzureOidcAuthenticator` to the new
9+
`OpenIdConnectExceptionInterface` marker, since concrete exceptions no longer extend the deprecated
10+
`ItkOpenIdConnectException`. Added regression tests covering the exception-mapping branches and the
11+
authenticator's claim-to-tenant-role provisioning and de-provisioning logic.
12+
- Bounded OIDC provider HTTP calls (discovery, JWKS, token exchange) with an explicit
13+
`http_client_options.timeout` on both providers, configurable via the new `OIDC_HTTP_TIMEOUT` env var
14+
(default 5s). Previously no timeout was set anywhere in the chain, so Guzzle waited indefinitely and a
15+
hung/slow IdP could tie up a php-fpm worker.
716
- Removed the deprecated feed types `SparkleIOFeedType`, `EventDatabaseApiFeedType` and `KobaFeedType`.
817
Made the unknown-feed-type handling consistent: **reads degrade, writes are rejected.** Feed sources
918
(and feeds) that reference a removed type keep loading — item and collection reads return them with no

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"doctrine/doctrine-migrations-bundle": "^3.1",
2222
"doctrine/orm": "^2.9",
2323
"gesdinet/jwt-refresh-token-bundle": "^1.0",
24-
"itk-dev/openid-connect-bundle": "^4.1",
24+
"itk-dev/openid-connect-bundle": "^5.0",
2525
"justinrainbow/json-schema": "^5.2",
2626
"kubawerlos/php-cs-fixer-custom-fixers": "^3.11",
2727
"lexik/jwt-authentication-bundle": "^2.14",

0 commit comments

Comments
 (0)