Refactored how templates are handled#261
Merged
Merged
Conversation
| // @see docs/custom-templates.md | ||
| const templateModules = import.meta.glob("../templates/*.jsx", { eager: true }); | ||
| const customTemplatesModules = import.meta.glob("../custom-templates/*.jsx", { | ||
| eager: true, |
|
|
||
| The following files are required for a custom template: | ||
|
|
||
| * custom-template-name.jsx - A javascript module for the template. |
Contributor
There was a problem hiding this comment.
I guess technically it is a JavaScript XML module if it is .jsx
| import PropTypes from "prop-types"; | ||
| import UserContext from "./context/user-context"; | ||
| import NoAccess from "./components/no-access/no-access"; | ||
| import UserContext from "../context/user-context.jsx"; |
| const [themesOptions, setThemesOptions] = useState(); | ||
| const [displayPreview, setDisplayPreview] = useState(null); | ||
| const [templateError, setTemplateError] = useState(false); | ||
| const [disableLivePreview, setDisableLivePreview] = useState(false); |
Contributor
There was a problem hiding this comment.
Suggested change
| const [disableLivePreview, setDisableLivePreview] = useState(false); | |
| const [enablePreview, setEnablePreview] = useState(true); |
| </div> | ||
|
|
||
| {selectedTemplate?.resources?.options?.disableLivePreview && ( | ||
| {disableLivePreview && ( |
Contributor
There was a problem hiding this comment.
Suggested change
| {disableLivePreview && ( | |
| {enablePreview && ( |
| )} | ||
| {!selectedTemplate?.resources?.options?.disableLivePreview && | ||
| selectedTemplate?.resources?.component && ( | ||
| {!disableLivePreview && ( |
Contributor
There was a problem hiding this comment.
Suggested change
| {!disableLivePreview && ( | |
| {!enablePreview && ( |
| const [themesOptions, setThemesOptions] = useState(); | ||
| const [displayPreview, setDisplayPreview] = useState(null); | ||
| const [templateError, setTemplateError] = useState(false); | ||
| const [disableLivePreview, setDisableLivePreview] = useState(false); |
Contributor
There was a problem hiding this comment.
This state is never changed in the file......
sinejespersen
suggested changes
Aug 25, 2025
sinejespersen
left a comment
sinejespersen
left a comment
Contributor
There was a problem hiding this comment.
Some small comments, nothing big
Co-authored-by: Sine Jespersen <sinje@aarhus.dk>
Co-authored-by: Sine Jespersen <sinje@aarhus.dk>
Co-authored-by: Sine Jespersen <sinje@aarhus.dk>
Co-authored-by: Sine Jespersen <sinje@aarhus.dk>
Co-authored-by: Sine Jespersen <sinje@aarhus.dk>
sinejespersen
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
#249
Description
Refactored how templates are handled:
Checklist