Online check

[tuj]

Link to issue

#249

Description

Added online check.

Checklist

• My code is covered by test cases.
• My code passes our test (all our tests).
• My code passes our static analysis suite.
• My code passes our continuous integration process.

[turegjorup]

The current URL is https://os2display.example.com/client/online-check/ (note /client). This will change that to https://os2display.example.com/online-check/ without making a redirect which is an unnecessary breaking change.

Please move the files to /public/client/online-check so that 1) we don't change the url, 2) it scopes the files to the client

[turegjorup]

Suggested change

	* Added online-check to public.
	* Added (screen) client online-check to public.

[tuj]

Atm /client/online-check/ is not served as static files. The nginx config should be modified.

README.md should also have a section added with a description of the Online Check setup.

[turegjorup]

Have updated the nginx config so /client/online-check is served correctly.

Question. Why is this necessary?

# /config/routes.yaml

client:
    path: /client{subroutes}
    requirements:
        # https://symfony.com/doc/current/routing.html#slash-characters-in-route-parameters
        subroutes: '.*'
    methods: ['GET']
    controller: App\Controller\Client\ClientController

What are the subroutes used for?

[tuj]

Have updated the nginx config so /client/online-check is served correctly.

Question. Why is this necessary?

# /config/routes.yaml

client:
    path: /client{subroutes}
    requirements:
        # https://symfony.com/doc/current/routing.html#slash-characters-in-route-parameters
        subroutes: '.*'
    methods: ['GET']
    controller: App\Controller\Client\ClientController

What are the subroutes used for?

For the Admin and Template routes they are used for passing all the path handling to the react app. This is not actually needed for the client, and should be removed.

[turegjorup]

For the Admin and Template routes they are used for passing all the path handling to the react app. This is not actually needed for the client, and should be removed.

Good point. Didn't think about client side routing in the admin app. I think we can leave it in for consistency.