Screen layout commands and expanded documentation#296
Merged
Conversation
turegjorup
approved these changes
Sep 16, 2025
turegjorup
left a comment
turegjorup
left a comment
Contributor
There was a problem hiding this comment.
This can be merged but I think it would be beneficial to work more cleanly with available vs installed templates and layouts.
Logic for checking if a template or layout is installed is spread througout leading to code that is harder to follow and debug than necessary. I think it should be possible to consolidate that logic in the two service classes. Thus all other code could call ->getInstalledTemplates|Layouts(). This way other code would be more readable .
|
|
||
| public function updateScreenLayout(ScreenLayoutData $screenLayoutToUpdate): void | ||
| { | ||
| if (null !== $screenLayoutToUpdate->screenLayoutEntity) { |
Contributor
There was a problem hiding this comment.
A comment about what ->screenLayoutEntity signifies and the reason for the null check will help us down the road
…:os2display/display-api-service into feature/documentation-and-screen-layouts
turegjorup
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#249
Description
Checklist