Psalm to phpstan#417
Merged
Merged
Conversation
Locks down that getUrls() persists oauth2provider/oauth2state/oauth2nonce on the request session after the switch from autowired SessionInterface to Request::getSession(). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
preg_replace can return null on runtime PCRE errors (backtrack/recursion limits, /u with bad UTF-8) even after preg_match succeeded. The previous casts silently turned that into an empty title, letting an event through with no filter applied. The title filter is a correctness boundary, so on PCRE error the event is now omitted with an error log instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
turegjorup
approved these changes
Apr 30, 2026
turegjorup
left a comment
turegjorup
left a comment
Contributor
There was a problem hiding this comment.
Added two commits to handle review issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/7329
Description
Changed code analysis from Psalm to PHPStan.
Regarding change to src/Controller/Api/AuthOidcController.php see https://symfony.com/doc/current/session.html#basic-usage. This change should be manually tested after deploy.
Checklist