Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

- Removed a dead statement in `MediaRepository::getPaginator()` that referenced the undefined
variables `$page` and `$itemsPerPage`; the computed value was never used.
- Fixed inverted user-type guard in `UserService::activateExternalUser()`: the "user is not of
external type" check could never trigger due to a stray negation (`=== !$user->getUserType()`).
The endpoint was still protected by `ExternalUserAuthenticator`, so this restores the intended
Expand Down
12 changes: 0 additions & 12 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -2112,18 +2112,6 @@ parameters:
count: 1
path: src/Repository/MediaRepository.php

-
message: '#^Undefined variable\: \$itemsPerPage$#'
identifier: variable.undefined
count: 1
path: src/Repository/MediaRepository.php

-
message: '#^Undefined variable\: \$page$#'
identifier: variable.undefined
count: 1
path: src/Repository/MediaRepository.php

-
message: '#^Class App\\Repository\\PlaylistRepository has PHPDoc tag @method for method findBy\(\) parameter \#1 \$criteria with no value type specified in iterable type array\.$#'
identifier: missingType.iterableValue
Expand Down
2 changes: 0 additions & 2 deletions src/Repository/MediaRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ public function getById(Ulid $mediaId): QueryBuilder

public function getPaginator(Ulid $slideUlid): QueryBuilder
{
$firstResult = ($page - 1) * $itemsPerPage;

$queryBuilder = $this->_em->createQueryBuilder();
$queryBuilder->select('s')
->from(Slide::class, 's')
Expand Down
Loading