perf(wt_bridge): reduce hot-path allocations and syscalls#375
Merged
Conversation
broadcast(): hold the mutex during iteration instead of copying the subscriber slice on every packet. All channel operations are non-blocking (select with default), so lock duration is bounded. Eliminates ~10k slice allocations/sec at typical RTP rates. runSession(): merge the 2-byte length header and packet body into a single stream.Write using a reusable buffer. Halves the number of write syscalls per subscriber per packet. Also bump the forwarded-count log interval from 100k to 150k packets (~15 s at the user's observed rate). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscriber-slice copy per packet. All channel ops are non-blocking
(
selectwithdefault), so lock duration is bounded. Eliminates~10k slice allocs/sec at typical RTP rates.
single
stream.Writevia a reusable buffer. Halves write-syscallcount per subscriber per packet.
Test plan
go buildpasses🤖 Generated with Claude Code