Wizard: clear timezone and locale for unsupported image types

Rely on the existing restrictions system to clear wizard state when
image types don't support timezone or locale. Add clearTimezone and
clearLocale reducers to atomically reset related state (timezone + NTP
servers, languages + keyboard).

Co-authored-by: Gianluca Zuccarelli <gzuccare@redhat.com>

Author: jlsherrill

src/Components/CreateImageWizard/CreateImageWizard.tsx

@@ -23,6 +23,8 @@ import {
   changeArchitecture,
   changeDistribution,
   changeTimezone,
+  clearLocale,
+  clearTimezone,
   initializeWizard,
   selectDistribution,
   selectImageSource,
@@ -308,6 +310,13 @@ const CreateImageWizard = ({ isEdit }: CreateImageWizardProps) => {
       return;
     }
 
+    if (restrictions.timezone.shouldHide) {
+      if (timezone) {
+        dispatch(clearTimezone());
+      }
+      return;
+    }
+
     const defaultTimezone =
       distribution === RHEL_10 || targetEnvironments.includes('azure')
         ? DEFAULT_TIMEZONE
@@ -316,7 +325,24 @@ const CreateImageWizard = ({ isEdit }: CreateImageWizardProps) => {
     if (!timezone) {
       dispatch(changeTimezone(defaultTimezone));
     }
-  }, [distribution, targetEnvironments, isEdit, dispatch]);
+  }, [
+    distribution,
+    targetEnvironments,
+    isEdit,
+    dispatch,
+    restrictions.timezone.shouldHide,
+    timezone,
+  ]);
+
+  useEffect(() => {
+    if (isEdit) {
+      return;
+    }
+
+    if (restrictions.locale.shouldHide) {
+      dispatch(clearLocale());
+    }
+  }, [isEdit, dispatch, restrictions.locale.shouldHide]);
 
   // Duplicating some of the logic from the Wizard component to allow for custom nav items status
   // for original code see https://github.com/patternfly/patternfly-react/blob/184c55f8d10e1d94ffd72e09212db56c15387c5e/packages/react-core/src/components/Wizard/WizardNavInternal.tsx#L128

src/Components/CreateImageWizard3/CreateImageWizard3.tsx

@@ -30,6 +30,8 @@ import {
   changeProxy,
   changeServerUrl,
   changeTimezone,
+  clearLocale,
+  clearTimezone,
   initializeWizard,
   loadWizardState,
   selectDistribution,
@@ -265,6 +267,13 @@ const CreateImageWizard3 = () => {
       return;
     }
 
+    if (restrictions.timezone.shouldHide) {
+      if (timezone) {
+        dispatch(clearTimezone());
+      }
+      return;
+    }
+
     const defaultTimezone =
       distribution === RHEL_10 || targetEnvironments.includes('azure')
         ? DEFAULT_TIMEZONE
@@ -273,7 +282,24 @@ const CreateImageWizard3 = () => {
     if (!timezone) {
       dispatch(changeTimezone(defaultTimezone));
     }
-  }, [distribution, targetEnvironments, mode, dispatch]);
+  }, [
+    distribution,
+    targetEnvironments,
+    mode,
+    dispatch,
+    restrictions.timezone.shouldHide,
+    timezone,
+  ]);
+
+  useEffect(() => {
+    if (mode !== 'create') {
+      return;
+    }
+
+    if (restrictions.locale.shouldHide) {
+      dispatch(clearLocale());
+    }
+  }, [mode, dispatch, restrictions.locale.shouldHide]);
 
   useEffect(() => {
     if (!isOnPremise && showWizardModal && !hasTrackedWizardOpenedRef.current) {

src/store/api/distributions/constants.ts

@@ -73,7 +73,7 @@ export const DISTRO_DETAILS: Record<string, ImageTypeInfo> = {
   },
   'network-installer': {
     name: 'network-installer',
-    supported_blueprint_options: ['locale', 'fips'],
+    supported_blueprint_options: ['fips', 'locale'],
   },
   'pxe-tar-xz': {
     name: 'pxe-tar-xz',

src/store/api/distributions/tests/distributionDetailsApi.test.ts

@@ -50,11 +50,11 @@ describe('DISTRO_DETAILS configuration', () => {
   });
 
   describe('network-installer restrictions', () => {
-    it('should only allow locale and fips for network-installer', () => {
+    it('should only allow fips and locale for network-installer', () => {
       const networkInstallerSupported =
         DISTRO_DETAILS['network-installer'].supported_blueprint_options;
 
-      expect(networkInstallerSupported).toEqual(['locale', 'fips']);
+      expect(networkInstallerSupported).toEqual(['fips', 'locale']);
     });
   });
 

src/store/api/distributions/tests/hooks.test.tsx

@@ -247,6 +247,7 @@ describe('useCustomizationRestrictions hook logic', () => {
       expect(result.packages.shouldHide).toBe(true);
       expect(result.filesystem.shouldHide).toBe(true);
       expect(result.kernel.shouldHide).toBe(true);
+      expect(result.timezone.shouldHide).toBe(true);
       expect(result.users.shouldHide).toBe(true);
     });
 

src/store/api/distributions/tests/mocks/fixtures.ts

@@ -64,8 +64,8 @@ export const mockImageTypes = {
     'aap',
   ]),
   networkInstallerMinimal: createMockImageType('network-installer', [
-    'locale',
     'fips',
+    'locale',
   ]),
   wslWithoutFilesystemKernelOpenscap: createMockImageType('wsl', [
     'packages',

src/store/slices/wizard/index.ts

@@ -1466,6 +1466,10 @@ export const wizardSlice = createSlice({
     clearLanguages: (state) => {
       state.locale.languages = [];
     },
+    clearLocale: (state) => {
+      state.locale.languages = [];
+      state.locale.keyboard = '';
+    },
     changeKeyboard: (state, action: PayloadAction<string>) => {
       state.locale.keyboard = action.payload;
     },
@@ -1616,6 +1620,10 @@ export const wizardSlice = createSlice({
         }
       }
     },
+    clearTimezone: (state) => {
+      state.timezone.timezone = '';
+      state.timezone.ntpservers = [];
+    },
     changeHostname: (state, action: PayloadAction<string>) => {
       state.hostname = action.payload;
     },
@@ -1844,6 +1852,7 @@ export const {
   removeLanguage,
   replaceLanguage,
   clearLanguages,
+  clearLocale,
   changeKeyboard,
   changeBlueprintName,
   setIsCustomName,
@@ -1877,6 +1886,7 @@ export const {
   changeAapTlsConfirmation,
   addNtpServer,
   removeNtpServer,
+  clearTimezone,
   changeHostname,
   addPort,
   removePort,

src/store/slices/wizard/tests/wizardSlice.test.ts

@@ -5,6 +5,8 @@ import wizardReducer, {
   changeArchitecture,
   changeDistribution,
   changeImageTypes,
+  clearLocale,
+  clearTimezone,
   initializeWizard,
   initialState,
   loadWizardState,
@@ -232,4 +234,52 @@ describe('wizardSlice core reducers', () => {
       });
     });
   });
+
+  describe('clearLocale', () => {
+    it('should reset languages and keyboard', () => {
+      const stateWithLocale: wizardState = {
+        ...initialState,
+        locale: {
+          languages: ['en_US.UTF-8', 'fr_FR.UTF-8'],
+          keyboard: 'us',
+        },
+      };
+
+      const result = wizardReducer(stateWithLocale, clearLocale());
+
+      expect(result.locale.languages).toEqual([]);
+      expect(result.locale.keyboard).toBe('');
+    });
+
+    it('should be a no-op on already empty locale state', () => {
+      const result = wizardReducer(initialState, clearLocale());
+
+      expect(result.locale.languages).toEqual([]);
+      expect(result.locale.keyboard).toBe('');
+    });
+  });
+
+  describe('clearTimezone', () => {
+    it('should reset timezone and ntpservers', () => {
+      const stateWithTimezone: wizardState = {
+        ...initialState,
+        timezone: {
+          timezone: 'America/New_York',
+          ntpservers: ['0.pool.ntp.org', '1.pool.ntp.org'],
+        },
+      };
+
+      const result = wizardReducer(stateWithTimezone, clearTimezone());
+
+      expect(result.timezone.timezone).toBe('');
+      expect(result.timezone.ntpservers).toEqual([]);
+    });
+
+    it('should be a no-op on already empty timezone state', () => {
+      const result = wizardReducer(initialState, clearTimezone());
+
+      expect(result.timezone.timezone).toBe('');
+      expect(result.timezone.ntpservers).toEqual([]);
+    });
+  });
 });

src/test/Components/CreateImageWizard/steps/ImageOutput/ImageOutput.test.tsx

@@ -3,7 +3,16 @@
 // Redux State → mapRequestFromState() → API Request. They could be replaced by unit
 // tests for the request mapper functions (mapRequestToState/mapRequestFromState) which
 // would be faster and more focused than full integration tests.
-import { EDIT_BLUEPRINT } from '../../../../../constants';
+import { screen, within } from '@testing-library/react';
+
+import { CreateBlueprintRequest } from '@/store/api/backend';
+import { clickWithWait, createUser } from '@/test/testUtils';
+
+import {
+  CREATE_BLUEPRINT,
+  EDIT_BLUEPRINT,
+  RHEL_10,
+} from '../../../../../constants';
 import { mockBlueprintIds } from '../../../../fixtures/blueprints';
 import {
   aarch64CreateBlueprintRequest,
@@ -13,8 +22,14 @@ import {
   x86_64CreateBlueprintRequest,
 } from '../../../../fixtures/editMode';
 import {
+  blueprintRequest,
+  enterBlueprintName,
+  goToReview,
+  interceptBlueprintRequest,
   interceptEditBlueprintRequest,
+  renderCreateMode,
   renderEditMode,
+  selectGuestImageTarget,
 } from '../../wizardTestUtils';
 
 describe('Image output edit mode', () => {
@@ -82,3 +97,103 @@ describe('Image output edit mode', () => {
     expect(receivedRequest).toEqual(expectedRequest);
   });
 });
+
+const selectNetworkInstaller = async () => {
+  const user = createUser();
+  const checkbox = await screen.findByRole('checkbox', {
+    name: /Network installer checkbox/i,
+  });
+  await clickWithWait(user, checkbox);
+  return checkbox;
+};
+
+describe('Network installer target', () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  test('selecting network-installer shows alert and disables other checkboxes', async () => {
+    await renderCreateMode();
+    const networkInstallerCheckbox = await selectNetworkInstaller();
+
+    await screen.findByText(
+      /This image type requires specific, minimal configuration for remote installation/i,
+    );
+    const guestImageCheckbox = await screen.findByRole('checkbox', {
+      name: /Virtualization guest image/i,
+    });
+    expect(guestImageCheckbox).toBeDisabled();
+
+    const bareMetalCheckbox = await screen.findByRole('checkbox', {
+      name: /Bare metal installer/i,
+    });
+    expect(bareMetalCheckbox).toBeDisabled();
+
+    expect(networkInstallerCheckbox).toBeChecked();
+    expect(networkInstallerCheckbox).toBeEnabled();
+  });
+
+  test('selecting another target first disables network-installer', async () => {
+    await renderCreateMode();
+    await selectGuestImageTarget();
+
+    const networkInstallerCheckbox = await screen.findByRole('checkbox', {
+      name: /Network installer checkbox/i,
+    });
+    expect(networkInstallerCheckbox).toBeDisabled();
+  });
+
+  test('selecting network-installer only shows base settings, advanced settings, and review steps', async () => {
+    await renderCreateMode();
+    await selectNetworkInstaller();
+
+    const navigation = await screen.findByRole('navigation', {
+      name: /wizard steps/i,
+    });
+
+    const stepButtons = within(navigation).getAllByRole('button');
+    expect(stepButtons).toHaveLength(3);
+
+    expect(
+      within(navigation).getByRole('button', { name: /base settings/i }),
+    ).toBeInTheDocument();
+    expect(
+      within(navigation).getByRole('button', { name: /advanced settings/i }),
+    ).toBeInTheDocument();
+    expect(
+      within(navigation).getByRole('button', { name: /review/i }),
+    ).toBeInTheDocument();
+  });
+
+  test('can create a blueprint with network-installer', async () => {
+    await renderCreateMode();
+    await selectNetworkInstaller();
+    await enterBlueprintName('Red Velvet');
+
+    await goToReview();
+
+    const receivedRequest = await interceptBlueprintRequest(CREATE_BLUEPRINT);
+
+    const expectedRequest: CreateBlueprintRequest = {
+      ...blueprintRequest,
+      distribution: RHEL_10,
+      customizations: {
+        locale: {
+          languages: ['C.UTF-8'],
+        },
+      },
+      image_requests: [
+        {
+          architecture: 'x86_64',
+          image_type: 'network-installer',
+          upload_request: {
+            options: {},
+            type: 'aws.s3',
+          },
+        },
+      ],
+    };
+
+    expect(receivedRequest).toEqual(expectedRequest);
+  });
+});