multi: remove dummy 'image-mode' distribution

Now that hosted and on-prem share a unified approach to image mode
builds (via the bootc field and a proper getDistributions query), the
'image-mode' dummy distribution is no longer needed.

This removes the IMAGE_MODE constant, asDistribution/isImageMode type
guards, and the 'image-mode' union from all types. The on-prem
getArchitectures endpoint now uses the hosted GetArchitecturesApiArg
directly, and toComposerComposeRequest clears the distribution based
on the bootc field rather than matching a magic string.

Author: kingsleyzissou

src/Components/CreateImageWizard/steps/ImageOutput/components/BlueprintMode.tsx

@@ -22,7 +22,6 @@ import {
   selectDistribution,
   selectIsImageMode,
 } from '@/store/slices/wizard';
-import { asDistribution } from '@/store/typeGuards';
 import { getHostDistro } from '@/Utilities/getHostInfo';
 
 const BlueprintMode = () => {
@@ -40,11 +39,9 @@ const BlueprintMode = () => {
     const fetchDefaultDistro = async () => {
       try {
         const distro = await getHostDistro();
-        setDefaultDistro(asDistribution(distro as Distributions));
+        setDefaultDistro(distro as Distributions);
       } catch {
         // defaultDistro remains RHEL_10
-        // this is fine since image-mode is
-        // limited to RHEL_10 for now
       }
     };
 
@@ -81,14 +78,12 @@ const BlueprintMode = () => {
           isSelected={isImageMode}
           onChange={() => {
             if (!isOnPremise) {
-              previousDistro.current = distribution as Distributions;
+              previousDistro.current = distribution;
               previousArch.current = architecture;
             }
             dispatch(changeBlueprintMode('image'));
             dispatch(changeImageTypes([]));
-            if (isOnPremise) {
-              dispatch(changeDistribution('image-mode'));
-            } else {
+            if (!isOnPremise) {
               dispatch(changeArchitecture(X86_64));
               dispatch(changeImageSource(RHEL_10_IMAGE_MODE_IMAGE));
             }

src/Components/CreateImageWizard/steps/ImageOutput/tests/BlueprintMode.test.tsx

@@ -103,13 +103,14 @@ describe('BlueprintMode', () => {
       expect(store.getState().wizard.blueprintMode).toBe('image');
     });
 
-    test('updates distribution when switching to image mode', async () => {
+    test('does not change distribution when switching to image mode', async () => {
       const { store } = renderBlueprintMode();
       const user = createUser();
+      const distributionBefore = store.getState().wizard.distribution;
 
       await toggleBlueprintMode(user, 'image');
 
-      expect(store.getState().wizard.distribution).toBe('image-mode');
+      expect(store.getState().wizard.distribution).toBe(distributionBefore);
     });
 
     test('updates store when switching to package mode', async () => {

src/Components/CreateImageWizard/steps/ImageOutput/tests/ImageSourceSelect.test.tsx

@@ -3,7 +3,6 @@ import React from 'react';
 import { screen, waitFor } from '@testing-library/react';
 import { vi } from 'vitest';
 
-import { IMAGE_MODE } from '@/constants';
 import {
   selectDistribution,
   selectImageSource as selectImageSourceState,
@@ -39,7 +38,6 @@ vi.mock('@/store/api/backend', async (importOriginal) => {
 
 const renderHostedImageSourceSelect = () => {
   return renderWithRedux(<ImageSourceSelect />, {
-    distribution: IMAGE_MODE,
     blueprintMode: 'image',
   });
 };

src/Components/CreateImageWizard/steps/ImageOutput/tests/helpers.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 
 import { screen } from '@testing-library/react';
 
-import { IMAGE_MODE, RHEL_10 } from '@/constants';
+import { RHEL_10 } from '@/constants';
 import {
   clickWithWait,
   renderWithRedux,
@@ -136,7 +136,6 @@ export const renderImageSourceSelect = (
   return renderWithRedux(
     <ImageSourceSelect />,
     {
-      distribution: IMAGE_MODE,
       blueprintMode: 'image',
       ...wizardStateOverrides,
     },

src/Components/CreateImageWizard/steps/Kernel/components/KernelArguments.tsx

@@ -14,7 +14,6 @@ import {
   selectDistribution,
   selectKernel,
 } from '@/store/slices/wizard';
-import { asDistribution } from '@/store/typeGuards';
 
 const KernelArguments = () => {
   const kernelAppend = useAppSelector(selectKernel).append;
@@ -26,7 +25,7 @@ const KernelArguments = () => {
 
   const { data: oscapProfileInfo } = useGetOscapCustomizationsQuery(
     {
-      distribution: asDistribution(release),
+      distribution: release,
       // @ts-ignore if complianceProfileID is undefined the query is going to get skipped, so it's safe here to ignore the linter here
       profile: complianceProfileID,
     },

src/Components/CreateImageWizard/steps/Locale/index.tsx

@@ -12,7 +12,6 @@ import {
   selectLocaleLangpackCandidates,
   selectVerifiedLocaleLangpacks,
 } from '@/store/slices/wizard';
-import { asDistribution } from '@/store/typeGuards';
 
 import KeyboardDropDown from './components/KeyboardDropDown';
 import LanguagesDropDown from './components/LanguagesDropDown';
@@ -23,7 +22,7 @@ const LocaleStep = () => {
   const candidateLangpacks = useAppSelector(selectLocaleLangpackCandidates);
   const { data: distroRepositories, isLoading: isArchitecturesLoading } =
     useGetArchitecturesQuery({
-      distribution: asDistribution(distribution),
+      distribution: distribution,
     });
 
   const distroUrls = useMemo(() => {

src/Components/CreateImageWizard/steps/Oscap/components/PolicySelector.tsx

@@ -26,7 +26,6 @@ import {
   setCompliancePolicy,
   setOscapProfile,
 } from '@/store/slices/wizard';
-import { asDistribution } from '@/store/typeGuards';
 
 import { useSelectorHandlers } from './useSelectorHandlers';
 
@@ -74,9 +73,7 @@ type PolicySelectorProps = {
 const PolicySelector = ({ isDisabled = false }: PolicySelectorProps) => {
   const policyID = useAppSelector(selectCompliancePolicyID);
   const policyTitle = useAppSelector(selectCompliancePolicyTitle);
-  const release = removeBetaFromRelease(
-    asDistribution(useAppSelector(selectDistribution)),
-  );
+  const release = removeBetaFromRelease(useAppSelector(selectDistribution));
   const majorVersion = release.split('-')[1];
   const dispatch = useAppDispatch();
   const [isOpen, setIsOpen] = useState(false);

src/Components/CreateImageWizard/steps/Oscap/components/ProfileDetails.tsx

@@ -21,13 +21,12 @@ import {
   selectComplianceProfileID,
   selectDistribution,
 } from '@/store/slices/wizard';
-import { asDistribution } from '@/store/typeGuards';
 
 import { removeBetaFromRelease } from '../removeBetaFromRelease';
 
 const ProfileDetails = (): JSX.Element => {
   const releaseRaw = useAppSelector(selectDistribution);
-  const release = removeBetaFromRelease(asDistribution(releaseRaw));
+  const release = removeBetaFromRelease(releaseRaw);
   const profileID = useAppSelector(selectComplianceProfileID);
 
   const { data, isFetching, error } = useGetOscapCustomizationsQuery(

src/Components/CreateImageWizard/steps/Oscap/components/ProfileSelector.tsx

@@ -35,7 +35,6 @@ import {
   selectDistribution,
   setOscapProfile,
 } from '@/store/slices/wizard';
-import { asDistribution } from '@/store/typeGuards';
 
 import { useSelectorHandlers } from './useSelectorHandlers';
 
@@ -63,9 +62,7 @@ const ProfileSelector = ({
 }: ProfileSelectorProps) => {
   const isOnPremise = useAppSelector(selectIsOnPremise);
   const profileID = useAppSelector(selectComplianceProfileID);
-  const release = removeBetaFromRelease(
-    asDistribution(useAppSelector(selectDistribution)),
-  );
+  const release = removeBetaFromRelease(useAppSelector(selectDistribution));
   const dispatch = useAppDispatch();
   const [isOpen, setIsOpen] = useState(false);
   const [inputValue, setInputValue] = useState<string>('');

src/Components/CreateImageWizard/steps/Oscap/components/SecurityInformation.tsx

@@ -26,7 +26,6 @@ import {
   selectDistribution,
   selectFips,
 } from '@/store/slices/wizard';
-import { asDistribution } from '@/store/typeGuards';
 
 export const SecurityInformation = (): JSX.Element => {
   const release = useAppSelector(selectDistribution);
@@ -44,7 +43,7 @@ export const SecurityInformation = (): JSX.Element => {
     error: profileError,
   } = useGetOscapCustomizationsQuery(
     {
-      distribution: asDistribution(release),
+      distribution: release,
       profile: complianceProfileID as unknown as DistributionProfileItem,
     },
     {
@@ -59,7 +58,7 @@ export const SecurityInformation = (): JSX.Element => {
     error: complianceError,
   } = useGetComplianceCustomizationsQuery(
     {
-      distribution: asDistribution(release),
+      distribution: release,
       policy: compliancePolicyID!,
     },
     {