Clear timezone and locale for unsupported image types (HMS-10456)

[kingsleyzissou]

Summary

Use the existing restrictions system to clear wizard state for timezone
and locale when the selected image type doesn't support them (e.g.,
network-installer), preventing stale customization data from leaking
into blueprint requests.

Changes

• Add clearTimezone and clearLocale reducers to atomically reset related state (timezone + NTP servers, languages + keyboard)
• Add useEffect hooks in both wizard versions to dispatch clearing actions when restrictions.*.shouldHide is true, with guards to skip edit mode and avoid redundant dispatches
• Add timezone.shouldHide assertion for network-installer in the restrictions hook tests
• Add integration tests for network-installer: checkbox mutual exclusion, wizard step reduction, and blueprint request verification with empty customizations
• Add unit tests for the new reducers covering reset and no-op cases

[kingsleyzissou]

#4311 got closed, I cherry-picked the changes from that and made some changes

[codecov]

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.20%. Comparing base (b5a74d4) to head (91a3e6a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...Components/CreateImageWizard/CreateImageWizard.tsx	77.77%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #4482      +/-   ##
==========================================
+ Coverage   76.05%   76.20%   +0.15%     
==========================================
  Files         225      225              
  Lines        7196     7204       +8     
  Branches     2662     2663       +1     
==========================================
+ Hits         5473     5490      +17     
+ Misses       1482     1473       -9     
  Partials      241      241              

Files with missing lines	Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx	85.89% <77.77%> (+0.05%)	⬆️

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a74d4...91a3e6a. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sourcery-ai]

Hey - I've left some high level feedback:

• The implementation still lists locale under network-installer supported_blueprint_options (and updates tests accordingly), which conflicts with the PR summary that says locale should be removed for this image type—please reconcile the intended behavior vs. the current constants/test expectations.
• In the useEffect that clears timezone when restrictions.timezone.shouldHide is true, the guard if (timezone) only checks the timezone string and could leave ntpservers uncleared if they are set while timezone is already empty; consider basing the condition on both fields or always dispatching clearTimezone when hidden.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The implementation still lists `locale` under `network-installer` supported_blueprint_options (and updates tests accordingly), which conflicts with the PR summary that says `locale` should be removed for this image type—please reconcile the intended behavior vs. the current constants/test expectations.
- In the `useEffect` that clears timezone when `restrictions.timezone.shouldHide` is true, the guard `if (timezone)` only checks the timezone string and could leave `ntpservers` uncleared if they are set while `timezone` is already empty; consider basing the condition on both fields or always dispatching `clearTimezone` when hidden.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[regexowl]

Looks good! One minor nitpick, but not blocking on that

Looking at the test failures, those seem to be relevant.

[kingsleyzissou]

Looking at the test failures, those seem to be relevant.

I had a suspicion but I haven't had the chance to look into it properly yet