Wizard: Fix kernel alert rendering (HMS-10579)#4492
Open
regexowl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
{' '}inserted after the</Content>closing tag is unnecessary and will render an extra space node; consider removing it to keep the JSX clean.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `{' '}` inserted after the `</Content>` closing tag is unnecessary and will render an extra space node; consider removing it to keep the JSX clean.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
5026145 to
d0c82d1
Compare
Collaborator
Author
Valid |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4492 +/- ##
=======================================
Coverage 75.34% 75.34%
=======================================
Files 229 229
Lines 7446 7446
Branches 2768 2770 +2
=======================================
Hits 5610 5610
Misses 1578 1578
Partials 258 258
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
The alert needs to be rendered outside of the Content block to be formatted properly.
d0c82d1 to
5fa10ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alert needs to be rendered outside of the Content block to be formatted properly.
Before:

After:
