Skip to content

Wizard: Fix kernel alert rendering (HMS-10579)#4492

Open
regexowl wants to merge 1 commit into
osbuild:mainfrom
regexowl:fix-kernel-alert
Open

Wizard: Fix kernel alert rendering (HMS-10579)#4492
regexowl wants to merge 1 commit into
osbuild:mainfrom
regexowl:fix-kernel-alert

Conversation

@regexowl
Copy link
Copy Markdown
Collaborator

@regexowl regexowl commented Jun 1, 2026

The alert needs to be rendered outside of the Content block to be formatted properly.

Before:
image

After:
image

@regexowl regexowl added 🔍 SPUR 🍼 simple Simple and quick to review labels Jun 1, 2026
@regexowl regexowl marked this pull request as ready for review June 1, 2026 13:21
@regexowl regexowl requested a review from a team as a code owner June 1, 2026 13:21
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The {' '} inserted after the </Content> closing tag is unnecessary and will render an extra space node; consider removing it to keep the JSX clean.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `{' '}` inserted after the `</Content>` closing tag is unnecessary and will render an extra space node; consider removing it to keep the JSX clean.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@regexowl regexowl force-pushed the fix-kernel-alert branch from 5026145 to d0c82d1 Compare June 1, 2026 13:23
@regexowl
Copy link
Copy Markdown
Collaborator Author

regexowl commented Jun 1, 2026

  • The {' '} inserted after the </Content> closing tag is unnecessary and will render an extra space node; consider removing it to keep the JSX clean.

Valid

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.34%. Comparing base (3e17596) to head (5fa10ac).

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4492   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files         229      229           
  Lines        7446     7446           
  Branches     2768     2770    +2     
=======================================
  Hits         5610     5610           
  Misses       1578     1578           
  Partials      258      258           
Files with missing lines Coverage Δ
...omponents/CreateImageWizard/steps/Kernel/index.tsx 87.50% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e17596...5fa10ac. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The alert needs to be rendered outside of the Content block to be formatted properly.
@regexowl regexowl force-pushed the fix-kernel-alert branch from d0c82d1 to 5fa10ac Compare June 3, 2026 09:45
@regexowl regexowl changed the title Wizard: Fix kernel alert rendering Wizard: Fix kernel alert rendering (HMS-10579) Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍼 simple Simple and quick to review 🔍 SPUR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant