Skip to content

Wizard: Prevent Users columns from overflowing the card on small screens (HMS-10579)#4501

Open
mgold1234 wants to merge 1 commit into
osbuild:mainfrom
mgold1234:add_change
Open

Wizard: Prevent Users columns from overflowing the card on small screens (HMS-10579)#4501
mgold1234 wants to merge 1 commit into
osbuild:mainfrom
mgold1234:add_change

Conversation

@mgold1234
Copy link
Copy Markdown
Collaborator

Wizard: Prevent Users columns from overflowing the card on small screens
Screenshot 2026-06-03 at 15 13 06

JIRA: (HMS-10579)

@mgold1234 mgold1234 marked this pull request as ready for review June 3, 2026 12:13
@mgold1234 mgold1234 requested a review from a team as a code owner June 3, 2026 12:14
@mgold1234 mgold1234 requested review from ksiekl, ochosi and tkoscieln June 3, 2026 12:14
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of using an inline style for overflowX: 'auto', consider using a PatternFly or app-level CSS/utility class so the layout behavior stays consistent and easier to maintain across similar components.
  • For responsiveness, it might be worth allowing flexWrap to switch to 'wrap' at smaller breakpoints (e.g., flexWrap={{ default: 'nowrap', md: 'wrap' }}) so narrow viewports don’t end up with an overly wide horizontal scroll when the card is very small.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of using an inline style for `overflowX: 'auto'`, consider using a PatternFly or app-level CSS/utility class so the layout behavior stays consistent and easier to maintain across similar components.
- For responsiveness, it might be worth allowing `flexWrap` to switch to `'wrap'` at smaller breakpoints (e.g., `flexWrap={{ default: 'nowrap', md: 'wrap' }}`) so narrow viewports don’t end up with an overly wide horizontal scroll when the card is very small.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.34%. Comparing base (29382df) to head (7607972).
⚠️ Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4501   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files         229      229           
  Lines        7446     7446           
  Branches     2770     2768    -2     
=======================================
  Hits         5610     5610           
  Misses       1578     1578           
  Partials      258      258           
Files with missing lines Coverage Δ
...w/components/AdvancedSettings/components/Users.tsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29382df...7607972. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant