playwright: fix tmt in dist-git#4504
Open
lucasgarfield wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider documenting or guarding against the case where both TMT_SOURCE_DIR and TMT_TREE are set, since the current ordering implicitly prefers TMT_SOURCE_DIR and that precedence might not be obvious to future readers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider documenting or guarding against the case where both TMT_SOURCE_DIR and TMT_TREE are set, since the current ordering implicitly prefers TMT_SOURCE_DIR and that precedence might not be obvious to future readers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4504 +/- ##
=======================================
Coverage 76.05% 76.05%
=======================================
Files 225 225
Lines 7196 7196
Branches 2660 2662 +2
=======================================
Hits 5473 5473
Misses 1482 1482
Partials 241 241 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Recently testing-farm tests were failing and a fix was merged in 3507013e where TMT_TREE is used instead of TMT_SOURCE_DIR. This got the CI working, but broke the tests when running in dist-git. We need to use TMT_TREE when in CI, and TMT_SOURCE_DIR when in dist-git. This commit adds the dist-git case back while keeping TMT_TREE for Packit.
lucasgarfield
force-pushed
the
fix-tmt-again
branch
from
8818650 to
e00fe60
Compare
kingsleyzissou
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently testing-farm tests were failing and a fix was merged in 3507013e where TMT_TREE is used instead of TMT_SOURCE.
This got the CI working, but broke the tests when running in dist-git.
We need to use TMT_SOURCE when in CI, and TMT_SOURCE_DIR when in dist-git. This commit adds the dist-git case back while keeping TMT_SOURCE for Packit.